Show academic year during preparation period

If we're in the preparation period, it's not always clear which academic
year is being used to display a year group, therefore we should always
show the academic year during the preparation period.

Author: thomasleese

app/helpers/patients_helper.rb

@@ -41,11 +41,15 @@ def patient_year_group(patient, academic_year:)
       patient.registration_academic_year == academic_year &&
         patient.registration.present?
 
-    str = str.dup if include_registration
+    include_academic_year =
+      academic_year != AcademicYear.current ||
+        AcademicYear.current != AcademicYear.pending
+
+    str = str.dup if include_registration || include_academic_year
 
     str << ", #{patient.registration}" if include_registration
 
-    if academic_year != AcademicYear.current
+    if include_academic_year
       str << " (#{format_academic_year(academic_year)} academic year)"
     end
 

spec/helpers/patients_helper_spec.rb

@@ -120,5 +120,21 @@
         it { should eq("Year 10 (2024 to 2025 academic year)") }
       end
     end
+
+    context "during the preparation period" do
+      let(:today) { Date.new(2024, 8, 1) }
+      let(:academic_year) { today.academic_year }
+
+      it { should eq("Year 9 (2023 to 2024 academic year)") }
+
+      context "with a registration" do
+        before do
+          patient.registration = "9AB"
+          patient.registration_academic_year = today.academic_year
+        end
+
+        it { should eq("Year 9, 9AB (2023 to 2024 academic year)") }
+      end
+    end
   end
 end