Refactor out bucket name (#3266)

- Bucket names are globally unique
- Being able to change the name with variables instead of file changes
is therefore ideal

Author: TheOneFromNorway

terraform/app/codedeploy.tf

@@ -53,7 +53,7 @@ resource "aws_codedeploy_deployment_group" "blue_green_deployment_group" {
 }
 
 resource "aws_s3_bucket" "code_deploy_bucket" {
-  bucket        = "appspec-bucket-${var.environment}"
+  bucket        = var.appspec_bucket
   force_destroy = true
 }
 

terraform/app/env/copilotmigration.tfvars

@@ -19,3 +19,4 @@ splunk_enabled = "false"
 cis2_enabled   = "false"
 pds_enabled    = "false"
 minimum_replicas = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-copilotmigration"

terraform/app/env/poc.tfvars

@@ -15,3 +15,4 @@ http_hosts = {
   MAVIS__HOST                        = "poc.mavistesting.com"
   MAVIS__GIVE_OR_REFUSE_CONSENT_HOST = "poc.mavistesting.com"
 }
+appspec_bucket = "nhse-mavis-appspec-bucket-poc"

terraform/app/env/preview.tfvars

@@ -23,3 +23,4 @@ http_hosts = {
 }
 
 minimum_replicas = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-preview"

terraform/app/env/production.tfvars

@@ -23,6 +23,7 @@ http_hosts = {
 }
 
 minimum_replicas        = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-production"
 account_id              = 820242920762
 vpc_log_retention_days  = 14
 ecs_log_retention_days  = 30

terraform/app/env/qa.tfvars

@@ -22,3 +22,4 @@ http_hosts = {
   MAVIS__GIVE_OR_REFUSE_CONSENT_HOST = "qa.mavistesting.com"
 }
 minimum_replicas = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-qa"

terraform/app/env/test.tfvars

@@ -22,3 +22,4 @@ http_hosts = {
   MAVIS__GIVE_OR_REFUSE_CONSENT_HOST = "test.mavistesting.com"
 }
 minimum_replicas = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-test"

terraform/app/env/training.tfvars

@@ -25,3 +25,4 @@ http_hosts = {
   MAVIS__GIVE_OR_REFUSE_CONSENT_HOST = "training.manage-vaccinations-in-schools.nhs.uk"
 }
 minimum_replicas = 3
+appspec_bucket = "nhse-mavis-appspec-bucket-training"

terraform/app/variables.tf

@@ -23,6 +23,12 @@ variable "access_logs_bucket" {
   description = "Name of the S3 bucket which stores access logs for various resources"
 }
 
+variable "appspec_bucket" {
+  type        = string
+  description = "Name of the S3 bucket which stores appspec files"
+  nullable    = false
+}
+
 variable "account_id" {
   type        = string
   default     = "393416225559"

terraform/scripts/bootstrap.sh

@@ -107,7 +107,7 @@ http_hosts = {
   MAVIS__GIVE_OR_REFUSE_CONSENT_HOST = "$ENV.mavistesting.com"
 }
 minimum_replicas     = 3
-db_delete_protection = true
+appspec_bucket       = "nhse-mavis-appspec-bucket-$ENV"
 
 EOF
 }