Merge pull request #4641 from nhsuk/fix-duplicate-session-activity-tabs

Ensure "Session activity and notes" only shows once

Author: thomasleese

app/views/patient_sessions/_header.html.erb

@@ -71,12 +71,12 @@
             selected: @programme == programme,
             ticked: @patient.vaccination_status(programme:, academic_year: @academic_year).vaccinated?,
           )
-      
-          nav.with_item(
-            href: session_patient_activity_path(@session, @patient, return_to: params[:return_to]),
-            text: "Session activity and notes",
-            selected: request.path.ends_with?("/activity"),
-          )
         end
+      
+        nav.with_item(
+          href: session_patient_activity_path(@session, @patient, return_to: params[:return_to]),
+          text: "Session activity and notes",
+          selected: request.path.ends_with?("/activity"),
+        )
       end %>
 <% end %>

spec/features/doubles_vaccination_administered_spec.rb

@@ -64,6 +64,8 @@ def when_i_go_to_a_patient_that_is_ready_to_vaccinate
     sign_in @nurse
     visit session_record_path(@session)
     click_link @patient.full_name
+
+    expect(page).to have_content("Session activity and notes").once
   end
 
   def then_i_see_the_menacwy_vaccination_form