Call Patient::TriageStatus#refresh!

This ensures that at each point where a triage record, vaccination
records or consent record is created or updated, we update the triage
status of the patient record.

I've decided to avoid using callbacks as I find they can lead to
suprising behaviour and this helps to keep the code explicit, however
I'm not against using callbacks if that's preferred.

Author: thomasleese

app/controllers/consent_forms_controller.rb

@@ -132,6 +132,7 @@ def set_consent_form
   def set_patient
     @patient =
       policy_scope(Patient).includes(
+        :triages,
         consents: :parent,
         parent_relationships: :parent,
         sessions_for_current_academic_year: :programmes

app/controllers/consents_controller.rb

@@ -136,14 +136,19 @@ def set_consent
   end
 
   def update_patient_status
-    Patient
-      .includes(consents: :parent)
-      .find(@patient.id)
+    patient = Patient.includes(:triages, consents: :parent).find(@patient.id)
+
+    patient
       .consent_statuses
       .find_or_initialize_by(programme: @consent.programme)
       .refresh!
 
-    @patient.triages.where(programme_id: @consent.programme_id).invalidate_all
+    patient
+      .triage_statuses
+      .find_or_initialize_by(programme: @consent.programme)
+      .refresh!
+
+    patient.triages.where(programme_id: @consent.programme_id).invalidate_all
   end
 
   def ensure_can_withdraw

app/controllers/draft_consents_controller.rb

@@ -60,12 +60,7 @@ def handle_confirm
       @consent.parent&.save!
       @consent.save!
 
-      Patient
-        .includes(consents: :parent)
-        .find(@patient.id)
-        .consent_statuses
-        .find_or_initialize_by(programme: @consent.programme)
-        .refresh!
+      update_patient_status
     end
 
     set_patient_session # reload with new consents
@@ -82,6 +77,20 @@ def handle_confirm
     }
   end
 
+  def update_patient_status
+    patient = Patient.includes(:triages, consents: :parent).find(@patient.id)
+
+    patient
+      .consent_statuses
+      .find_or_initialize_by(programme: @programme)
+      .refresh!
+
+    patient
+      .triage_statuses
+      .find_or_initialize_by(programme: @programme)
+      .refresh!
+  end
+
   def handle_questions
     questions_attrs = update_params.except(:wizard_step).values
     @draft_consent.health_answers.each_with_index do |ha, index|

app/controllers/vaccinations_controller.rb

@@ -79,7 +79,7 @@ def set_session
 
   def set_patient
     @patient =
-      policy_scope(Patient).includes(consents: :parent).find(
+      policy_scope(Patient).includes(:triages, consents: :parent).find(
         params.fetch(:patient_id) { params.fetch(:id) }
       )
   end

app/jobs/consent_form_matching_job.rb

@@ -50,7 +50,7 @@ def match_with_exact_nhs_number
     return false unless pds_patient
 
     patient =
-      Patient.includes(:school, consents: :parent).find_by(
+      Patient.includes(:school, :triages, consents: :parent).find_by(
         nhs_number: pds_patient.nhs_number
       )
     return false unless patient
@@ -64,7 +64,7 @@ def session_patients
       @consent_form
         .original_session
         .patients
-        .includes(:school, consents: :parent)
+        .includes(:school, :triages, consents: :parent)
         .match_existing(nhs_number: nil, **query)
   end
 

app/lib/patient_merger.rb

@@ -119,10 +119,11 @@ def self.call(*args, **kwargs)
   attr_reader :patient_to_keep, :patient_to_destroy
 
   def refresh_statuses
-    Patient
-      .includes(consents: :parent)
-      .find(patient_to_keep.id)
-      .consent_statuses
-      .find_each(&:refresh!)
+    patient =
+      Patient.includes(:triages, consents: :parent).find(patient_to_keep.id)
+
+    patient.consent_statuses.find_each(&:refresh!)
+
+    patient.triage_statuses.find_each(&:refresh!)
   end
 end

app/models/consent.rb

@@ -165,6 +165,7 @@ def self.from_consent_form!(consent_form, patient:, current_user:)
             )
 
           patient.consent_statuses.find_or_initialize_by(programme:).refresh!
+          patient.triage_statuses.find_or_initialize_by(programme:).refresh!
 
           consent
         end
@@ -186,6 +187,7 @@ def self.from_consent_form!(consent_form, patient:, current_user:)
             )
 
           patient.consent_statuses.find_or_initialize_by(programme:).refresh!
+          patient.triage_statuses.find_or_initialize_by(programme:).refresh!
 
           consent
         end

app/models/patient.rb

@@ -405,7 +405,8 @@ def self.from_consent_form(consent_form)
       organisation: consent_form.organisation,
       preferred_family_name: consent_form.preferred_family_name,
       preferred_given_name: consent_form.preferred_given_name,
-      school: consent_form.school
+      school: consent_form.school,
+      triages: []
     )
   end