Add validation on vaccine_method

This adds some validation on the `vaccine_method` column of the
`Consent` model to ensure that it's always set when the parent has given
consent. This value will be used as part of generating the overall
consent status so it's important that it's always present.

We can't validate that the `vaccine_method` is not set when refused
consent because it's possible for a parent to give consent and then
withdrawn it, in which case we would want to see what the method was
when consent was given.

Jira-Issue: MAV-1230

Author: thomasleese

app/models/consent.rb

@@ -70,7 +70,12 @@ class Consent < ApplicationRecord
        { website: 0, phone: 1, paper: 2, in_person: 3, self_consent: 4 },
        prefix: "via",
        validate: true
-  enum :vaccine_method, { injection: 0, nasal: 1 }, prefix: true
+  enum :vaccine_method,
+       { injection: 0, nasal: 1 },
+       prefix: true,
+       validate: {
+         if: :response_given?
+       }
 
   enum :reason_for_refusal,
        {

spec/factories/consent_form_programmes.rb

@@ -25,6 +25,14 @@
     consent_form
     programme
 
-    traits_for_enum :response
+    trait :given do
+      response { "given" }
+      vaccine_method { "injection" }
+    end
+
+    trait :refused do
+      response { "refused" }
+      vaccine_method { nil }
+    end
   end
 end

spec/factories/consent_forms.rb

@@ -123,8 +123,11 @@
     end
 
     after(:create) do |consent_form, evaluator|
+      vaccine_method = evaluator.response == "given" ? "injection" : nil
+
       consent_form.consent_form_programmes.update_all(
-        response: evaluator.response
+        response: evaluator.response,
+        vaccine_method:
       )
     end
 

spec/factories/consents.rb

@@ -65,6 +65,7 @@
     end
 
     response { "given" }
+    vaccine_method { "injection" }
     route { "website" }
 
     health_answers do
@@ -75,8 +76,6 @@
 
     submitted_at { consent_form&.recorded_at || Time.current }
 
-    traits_for_enum :response
-
     trait :given_verbally do
       given
       route { "phone" }
@@ -94,10 +93,16 @@
     end
 
     trait :refused do
-      response { :refused }
-      reason_for_refusal { :personal_choice }
+      response { "refused" }
+      reason_for_refusal { "personal_choice" }
       health_answers { [] }
       notes { "Refused." }
+      vaccine_method { nil }
+    end
+
+    trait :not_provided do
+      response { "not_provided" }
+      vaccine_method { nil }
     end
 
     trait :from_mum do

spec/models/consent_spec.rb

@@ -43,6 +43,26 @@
 describe Consent do
   describe "validations" do
     it { should validate_length_of(:notes).is_at_most(1000) }
+
+    context "when response is given" do
+      subject(:consent) { build(:consent, :given) }
+
+      it do
+        expect(consent).to validate_inclusion_of(:vaccine_method).in_array(
+          %w[injection nasal]
+        )
+      end
+    end
+
+    context "when response is refused" do
+      subject(:consent) { build(:consent, :refused) }
+
+      it do
+        expect(consent).not_to validate_inclusion_of(:vaccine_method).in_array(
+          %w[injection nasal]
+        )
+      end
+    end
   end
 
   describe "#verbal_routes" do
@@ -202,8 +222,14 @@
       end
 
       before do
-        consent_form.consent_form_programmes.first.update!(response: "given")
-        consent_form.consent_form_programmes.second.update!(response: "refused")
+        consent_form.consent_form_programmes.first.update!(
+          response: "given",
+          vaccine_method: "injection"
+        )
+        consent_form.consent_form_programmes.second.update!(
+          response: "refused",
+          vaccine_method: nil
+        )
       end
 
       it "creates a consent per programme" do