Merge pull request #4252 from nhsuk/deduplicate-programme-in-notice

Fix duplication of programme name in notice

Author: alistair-white-horne-tng

app/lib/important_notices.rb

@@ -71,7 +71,7 @@ def notices_for_patient(patient)
       patient.vaccination_records.select { it.notify_parents == false }
     if no_notify_vaccination_records.any?
       vaccinations_sentence =
-        "#{no_notify_vaccination_records.map(&:programme).map(&:name).to_sentence} " \
+        "#{no_notify_vaccination_records.map(&:programme).uniq.map(&:name).to_sentence} " \
           "#{"vaccination".pluralize(no_notify_vaccination_records.length)}"
 
       notices << {

spec/lib/important_notices_spec.rb

@@ -81,6 +81,25 @@
       end
     end
 
+    context "when patient has multiple vaccination records with the same programme" do
+      let(:first_record) do
+        create(:vaccination_record, patient:, programme:, notify_parents: false)
+      end
+      let(:second_record) do
+        create(:vaccination_record, patient:, programme:, notify_parents: false)
+      end
+
+      before do
+        first_record
+        second_record
+      end
+
+      it "only writes the programme name once in the message" do
+        expect(notices.count).to eq(1)
+        expect(notices.first[:message].scan("HPV").count).to eq(1)
+      end
+    end
+
     context "when patient has multiple vaccination records with the same notify_parents values" do
       let(:other_programme) { create(:programme, :flu) }