Cleanup deployment

- Remove unused components
- Cleanup deployment workflow

Author: TheOneFromNorway

.github/workflows/deploy-application.yml

@@ -137,6 +137,7 @@ jobs:
         with:
           name: ${{ inputs.environment }}-good-job-task-definition
           path: ${{ steps.create-good-job-task-definition.outputs.task-definition }}
+
   approve-deployments:
     name: Wait for approval if required
     runs-on: ubuntu-latest
@@ -169,16 +170,12 @@ jobs:
         uses: aws-actions/amazon-ecs-deploy-task-definition@v2
         with:
           task-definition: ${{ needs.prepare-deployment.outputs.web-task-definition-path }}
-      - name: Create appspec.yml
-        run: |
-          cp config/templates/appspec.yaml.tpl appspec.yaml
-          sed -i 's|<TASK_DEFINITION_ARN>||g' appspec.yaml
       - name: Deploy web service with CodeDeploy
         id: deploy-web-service
         uses: aws-actions/amazon-ecs-deploy-task-definition@v2
         with:
           task-definition: ${{ needs.prepare-deployment.outputs.web-task-definition-path }}
-          codedeploy-appspec: appspec.yaml
+          codedeploy-appspec: config/templates/appspec.yaml
           cluster: ${{ env.cluster_name }}
           service: mavis-${{ inputs.environment }}-web
           codedeploy-application: mavis-${{ inputs.environment }}

config/container_variables.yml

@@ -30,7 +30,7 @@ environments:
   sandbox-beta:
     RAILS_ENV: staging
     SENTRY_ENVIRONMENT: sandbox-beta
-    TEST_KEY: test-value
+    TEST: TEST
 
 # Tunable Variables Configuration
 # This section specifies environment-specific variables that will be populated into the SSM parameter store

config/templates/appspec.yaml.tpl renamed to config/templates/appspec.yaml

@@ -10,7 +10,7 @@ Resources:
   - TargetService:
       Type: AWS::ECS::Service
       Properties:
-        TaskDefinition: "<TASK_DEFINITION_ARN>"
+        TaskDefinition: ""
         LoadBalancerInfo:
           ContainerName: "application"
           ContainerPort: "4000"