test: Add tests for manual consent reminder behavior

Author: MartinVanIJcken

package.json

@@ -56,5 +56,6 @@
         }
       ]
     }
-  }
+  },
+  "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

spec/jobs/send_automatic_school_consent_reminders_job_spec.rb

@@ -3,10 +3,12 @@
 describe SendAutomaticSchoolConsentRemindersJob do
   subject(:perform_now) { described_class.perform_now(session) }
 
-  let(:programmes) { [create(:programme)] }
+  let(:programmes) { [create(:programme, :flu)] }
 
   let(:parents) { create_list(:parent, 2) }
 
+  let(:manual_reminder_patient) { create(:patient, parents:, team:) }
+
   let(:patient_with_initial_reminder_sent) do
     create(
       :patient,
@@ -19,9 +21,13 @@
   let(:patient_not_sent_reminder) do
     create(:patient, :consent_request_sent, parents:, programmes:)
   end
+  let(:patient_vaccinated_last_year) do
+    create(:patient, :consent_request_sent, parents:, programmes:)
+  end
   let(:patient_not_sent_reminder_joined_after_first_date) do
     create(:patient, :consent_request_sent, parents:, programmes:)
   end
+
   let(:patient_not_sent_request) { create(:patient, parents:, programmes:) }
   let(:patient_with_consent) do
     create(:patient, :consent_given_triage_not_needed, programmes:)
@@ -32,6 +38,7 @@
 
   let!(:patients) do
     [
+      manual_reminder_patient,
       patient_with_initial_reminder_sent,
       patient_not_sent_reminder,
       patient_not_sent_reminder_joined_after_first_date,
@@ -61,13 +68,25 @@
     )
   end
 
+  let(:user) { create(:user, team:) }
+
   before do
     ConsentNotification.request.update_all(sent_at: dates.first - 1.week)
     ConsentNotification.reminder.update_all(sent_at: dates.first)
 
     patient_not_sent_reminder_joined_after_first_date.consent_notifications.update_all(
       sent_at: dates.first + 1.day
     )
+
+    create(
+      :consent_notification,
+      patient: manual_reminder_patient,
+      session:,
+      programmes:,
+      type: :initial_reminder,
+      sent_at: dates.first - 9.days,
+      sent_by: user
+    )
   end
 
   around { |example| travel_to(today) { example.run } }
@@ -85,16 +104,17 @@
     let(:today) { dates.first - 1.week }
 
     it "sends notifications to one patient" do
-      expect(ConsentNotification).to receive(:create_and_send!).once.with(
+      expect(ConsentNotification).to receive(:create_and_send!).with(
         patient: patient_not_sent_reminder,
-        programmes:,
+        programmes: [programmes.first],
         session:,
-        type: :initial_reminder
+        type: :initial_reminder,
+        current_user: nil
       )
       perform_now
     end
 
-    it "records a notification" do
+    it "records notifications" do
       expect { perform_now }.to change(ConsentNotification, :count).by(1)
     end
 
@@ -106,6 +126,52 @@
         perform_now
       end
     end
+
+    context "when a manual reminder was sent more than three days ago" do
+      before do
+        create(
+          :consent_notification,
+          patient: patient_not_sent_reminder,
+          session:,
+          programmes:,
+          type: :initial_reminder,
+          sent_at: 4.days.ago,
+          sent_by: user
+        )
+      end
+
+      it "sends automatic reminders" do
+        expect { perform_now }.to change(ConsentNotification, :count).by(1)
+
+        notification = ConsentNotification.last
+        expect(notification.patient).to eq(patient_not_sent_reminder)
+        expect(notification.programmes.length).to eq(1)
+        expect(notification.automated_reminder?).to be true
+
+        programme_types = notification.programmes.map(&:type)
+        expect(programme_types).to match_array(programmes.map(&:type))
+      end
+    end
+
+    context "when a manual reminder was sent less than three days ago" do
+      let(:user) { create(:user, team:) }
+
+      before do
+        create(
+          :consent_notification,
+          patient: patient_not_sent_reminder,
+          session:,
+          programmes:,
+          type: :initial_reminder,
+          sent_at: 2.days.ago,
+          sent_by: user
+        )
+      end
+
+      it "does not send an automatic reminder" do
+        expect { perform_now }.not_to change(ConsentNotification, :count)
+      end
+    end
   end
 
   context "six days before the first session with reminders already sent" do
@@ -126,6 +192,31 @@
     end
   end
 
+  context "five days before the first session, eight before the second" do
+    let(:today) { dates.first - 5.days }
+    let(:user) { create(:user, team:) }
+
+    context "when a manual reminder was sent less than three days before the reminder should have gone out" do
+      it "does not send an automatic reminder because the first session's reminder should be skipped" do
+        expect { perform_now }.not_to change(
+          ConsentNotification.where(patient_id: manual_reminder_patient.id),
+          :count
+        )
+      end
+    end
+  end
+
+  context "2 days before the first session, six before the second" do
+    let(:today) { dates.first - 2.days }
+    let(:user) { create(:user, team:) }
+
+    context "when a manual reminder was sent less than three days before the reminder should have gone out" do
+      it "sends the reminder for the second session" do
+        expect { perform_now }.to change(ConsentNotification, :count).by(1)
+      end
+    end
+  end
+
   context "one day after the first session" do
     let(:today) { dates.first + 1.day }
 
@@ -153,21 +244,24 @@
         patient: patient_not_sent_reminder,
         programmes:,
         session:,
-        type: :initial_reminder
+        type: :initial_reminder,
+        current_user: nil
       )
 
       expect(ConsentNotification).to receive(:create_and_send!).once.with(
         patient: patient_not_sent_reminder_joined_after_first_date,
         programmes:,
         session:,
-        type: :initial_reminder
+        type: :initial_reminder,
+        current_user: nil
       )
 
       expect(ConsentNotification).to receive(:create_and_send!).once.with(
         patient: patient_with_initial_reminder_sent,
         programmes:,
         session:,
-        type: :subsequent_reminder
+        type: :subsequent_reminder,
+        current_user: nil
       )
 
       perform_now

spec/jobs/send_manual_school_consent_reminders_job_spec.rb

@@ -0,0 +1,96 @@
+# frozen_string_literal: true
+
+describe SendManualSchoolConsentRemindersJob do
+  subject(:perform_now) do
+    described_class.perform_now(session, current_user: user)
+  end
+
+  let(:programmes) { [create(:programme, :flu)] }
+  # Create an initial consent request notification
+  let(:request_notification) do
+    create(
+      :consent_notification,
+      patient:,
+      session:,
+      programmes:,
+      type: :request,
+      sent_at: dates.first - 2.weeks
+    )
+  end
+  let(:today) { dates.first - 1.week }
+  let(:team) { create(:team, programmes:) }
+  let(:location) { create(:school, team:) }
+  let(:patient) { create(:patient, team:) }
+  let(:user) { create(:user, team:) }
+
+  let(:dates) { [Date.new(2024, 1, 12), Date.new(2024, 1, 15)] }
+
+  let!(:session) do
+    create(
+      :session,
+      dates:,
+      send_consent_requests_at: dates.first - 3.weeks,
+      days_before_consent_reminders: 7,
+      location:,
+      programmes:,
+      team:
+    )
+  end
+
+  # Create a parent for the patient
+  let(:parent) { create(:parent) }
+
+  before do
+    create(:parent_relationship, patient:, parent:)
+    create(:patient_session, patient:, session:, programmes:)
+    patient.reload
+  end
+
+  around { |example| travel_to(today) { example.run } }
+
+  context "when the patient has not consented or been vaccinated" do
+    it "creates a notification" do
+      expect { perform_now }.to change(ConsentNotification, :count).by(1)
+
+      last_notification = ConsentNotification.last
+      expect(last_notification.patient).to eq(patient)
+      expect(last_notification.programmes).to match_array(programmes)
+      expect(last_notification.automated_reminder?).to be false
+      expect(last_notification.sent_by).to eq(user)
+    end
+  end
+
+  context "when the patient has already replied to the consent form" do
+    before do
+      patient.consent_status(
+        programme: programmes.first,
+        academic_year: AcademicYear.current
+      ).refused!
+    end
+
+    it "does not create a notification" do
+      expect { perform_now }.not_to change(ConsentNotification, :count)
+    end
+  end
+
+  context "when the patient has already been vaccinated" do
+    before do
+      patient.vaccination_status(
+        programme: programmes.first,
+        academic_year: AcademicYear.current
+      ).vaccinated!
+    end
+
+    it "does not create a notification" do
+      expect { perform_now }.not_to change(ConsentNotification, :count)
+    end
+  end
+
+  context "when the patient has opted out of notifications" do
+    before { patient.update(restricted_at: Time.current) }
+
+    it "does not create a notification" do
+      expect { perform_now }.not_to change(ConsentNotification, :count)
+    end
+  end
+end