Refactor Patient::NextActivity

This simplifies the next activity generation and moves it to a method on
to the `PatientSession` model since it's only used in once place.

Author: thomasleese

app/components/app_patient_session_search_result_card_component.rb

@@ -73,7 +73,7 @@ def action_required
     tag.ul(class: "nhsuk-list nhsuk-list--bullet") do
       safe_join(
         patient_session.programmes.map do |programme|
-          status = patient_session.patient.next_activity.status[programme]
+          status = patient_session.next_activity(programme:)
           tag.li("#{I18n.t(status, scope: :activity)} for #{programme.name}")
         end
       )

app/models/patient.rb

@@ -265,10 +265,6 @@ def year_group_changed?
     birth_academic_year_changed?
   end
 
-  def next_activity
-    @next_activity ||= Patient::NextActivity.new(self)
-  end
-
   def consent_status(programme:)
     # Use `find` to allow for preloading.
     consent_statuses.find { it.programme_id == programme.id } ||

app/models/patient/next_activity.rb

@@ -145,6 +145,20 @@ def ready_for_vaccinator?(programme: nil)
     end
   end
 
+  def next_activity(programme:)
+    return :report if patient.vaccination_status(programme:).vaccinated?
+
+    return :record if patient.consent_given_and_safe_to_vaccinate?(programme:)
+
+    return :triage if patient.triage_status(programme:).required?
+
+    consent_status = patient.consent_status(programme:)
+
+    return :consent if consent_status.no_response? || consent_status.conflicts?
+
+    :do_not_record
+  end
+
   def outstanding_programmes
     # If this patient hasn't been seen yet by a nurse for any of the programmes,
     # we don't want to show the banner.

app/models/patient_session.rb

@@ -109,4 +109,71 @@
       end
     end
   end
+
+  describe "#next_activity" do
+    subject { patient_session.next_activity(programme:) }
+
+    let(:patient) { patient_session.patient }
+
+    context "with no consent" do
+      it { should be(:consent) }
+    end
+
+    context "with consent refused" do
+      before { create(:patient_consent_status, :refused, patient:, programme:) }
+
+      it { should be(:do_not_record) }
+    end
+
+    context "with triaged as do not vaccinate" do
+      before do
+        create(:patient_consent_status, :given, patient:, programme:)
+        create(:patient_triage_status, :do_not_vaccinate, patient:, programme:)
+      end
+
+      it { should be(:do_not_record) }
+    end
+
+    context "with consent needing triage" do
+      before do
+        create(:patient_consent_status, :given, patient:, programme:)
+        create(:patient_triage_status, :required, patient:, programme:)
+      end
+
+      it { should be(:triage) }
+    end
+
+    context "with triaged as safe to vaccinate" do
+      before do
+        create(:patient_consent_status, :given, patient:, programme:)
+        create(:patient_triage_status, :safe_to_vaccinate, patient:, programme:)
+      end
+
+      it { should be(:record) }
+    end
+
+    context "with consent no triage needed" do
+      before { create(:patient_consent_status, :given, patient:, programme:) }
+
+      it { should be(:record) }
+    end
+
+    context "with an administered vaccination record" do
+      before do
+        create(:patient_consent_status, :given, patient:, programme:)
+        create(:patient_vaccination_status, :vaccinated, patient:, programme:)
+      end
+
+      it { should be(:report) }
+    end
+
+    context "with an un-administered vaccination record" do
+      before do
+        create(:patient_consent_status, :given, patient:, programme:)
+        create(:patient_vaccination_status, patient:, programme:)
+      end
+
+      it { should be(:record) }
+    end
+  end
 end