Rename none outcome statuses (#3229)

Author: thomasleese

app/components/app_consent_component.html.erb

@@ -1,6 +1,6 @@
 <%= render AppConsentStatusComponent.new(patient_session:, programme:) %>
 
-<% if patient.consent_outcome.none?(programme) %>
+<% if patient.consent_outcome.no_response?(programme) %>
   <% if latest_consent_request %>
     <p class="nhsuk-body">
       No-one responded to our requests for consent.

app/components/app_consent_component.rb

@@ -28,8 +28,9 @@ def latest_consent_request
   end
 
   def can_send_consent_request?
-    patient.consent_outcome.none?(programme) && patient.send_notifications? &&
-      session.open_for_consent? && patient.parents.any?
+    patient.consent_outcome.no_response?(programme) &&
+      patient.send_notifications? && session.open_for_consent? &&
+      patient.parents.any?
   end
 
   def status_colour(consent)

app/components/app_programme_session_table_component.rb

@@ -30,11 +30,13 @@ def percentage_stat(session:)
   end
 
   def no_response_count(session:)
-    number_stat(session:) { it.patient.consent_outcome.none?(programme) }
+    number_stat(session:) { it.patient.consent_outcome.no_response?(programme) }
   end
 
   def no_response_percentage(session:)
-    percentage_stat(session:) { it.patient.consent_outcome.none?(programme) }
+    percentage_stat(session:) do
+      it.patient.consent_outcome.no_response?(programme)
+    end
   end
 
   def triage_needed_count(session:)

app/components/app_session_actions_component.rb

@@ -34,7 +34,7 @@ def rows
   def no_consent_response_row
     consent_row(
       text: "No consent response",
-      status: Patient::ConsentOutcome::NONE
+      status: Patient::ConsentOutcome::NO_RESPONSE
     )
   end
 

app/controllers/consents_controller.rb

@@ -26,7 +26,7 @@ def create
   end
 
   def send_request
-    return unless @patient.consent_outcome.none?(@programme)
+    return unless @patient.consent_outcome.no_response?(@programme)
 
     # For programmes that are administered together we should send the consent request together.
     programmes =

app/models/patient/consent_outcome.rb

@@ -6,19 +6,19 @@ def initialize(patient)
   end
 
   STATUSES = [
-    NONE = :none,
+    NO_RESPONSE = :no_response,
     CONFLICTS = :conflicts,
     GIVEN = :given,
     REFUSED = :refused
   ].freeze
 
-  def given?(programme) = status[programme] == GIVEN
-
-  def refused?(programme) = status[programme] == REFUSED
+  def no_response?(programme) = status[programme] == NO_RESPONSE
 
   def conflicts?(programme) = status[programme] == CONFLICTS
 
-  def none?(programme) = status[programme] == NONE
+  def given?(programme) = status[programme] == GIVEN
+
+  def refused?(programme) = status[programme] == REFUSED
 
   def status
     @status ||=
@@ -57,7 +57,7 @@ def programme_status(programme)
     elsif consent_conflicts?(programme)
       CONFLICTS
     else
-      NONE
+      NO_RESPONSE
     end
   end
 

app/models/patient/next_activity.rb

@@ -37,7 +37,8 @@ def status_for_programme(programme)
 
     return TRIAGE if triage_outcome.required?(programme)
 
-    if consent_outcome.none?(programme) || consent_outcome.conflicts?(programme)
+    if consent_outcome.no_response?(programme) ||
+         consent_outcome.conflicts?(programme)
       return CONSENT
     end
 

app/models/patient/programme_outcome.rb

@@ -8,14 +8,14 @@ def initialize(patient)
   STATUSES = [
     VACCINATED = :vaccinated,
     COULD_NOT_VACCINATE = :could_not_vaccinate,
-    NONE = :none
+    NONE_YET = :none_yet
   ].freeze
 
   def vaccinated?(programme) = status[programme] == VACCINATED
 
   def could_not_vaccinate?(programme) = status[programme] == COULD_NOT_VACCINATE
 
-  def none?(programme) = status[programme] == NONE
+  def none_yet?(programme) = status[programme] == NONE_YET
 
   def status
     @status ||=
@@ -43,7 +43,7 @@ def programme_status(programme)
     elsif programme_could_not_vaccinate?(programme)
       COULD_NOT_VACCINATE
     else
-      NONE
+      NONE_YET
     end
   end
 

app/models/patient_session.rb

@@ -109,7 +109,7 @@ def destroy_if_safe!
   end
 
   def can_record_as_already_vaccinated?(programme:)
-    !session.today? && patient.programme_outcome.none?(programme)
+    !session.today? && patient.programme_outcome.none_yet?(programme)
   end
 
   def programmes
@@ -143,10 +143,10 @@ def ready_for_vaccinator?(programme: nil)
   def outstanding_programmes
     # If this patient hasn't been seen yet by a nurse for any of the programmes,
     # we don't want to show the banner.
-    return [] if programmes.all? { session_outcome.none?(it) }
+    return [] if programmes.all? { session_outcome.none_yet?(it) }
 
     programmes.select do
-      ready_for_vaccinator?(programme: it) && session_outcome.none?(it)
+      ready_for_vaccinator?(programme: it) && session_outcome.none_yet?(it)
     end
   end
 end

app/models/patient_session/register_outcome.rb

@@ -56,6 +56,6 @@ def session_date
   end
 
   def all_programmes_have_outcome?
-    programmes.none? { session_outcome.none?(it) }
+    programmes.none? { session_outcome.none_yet?(it) }
   end
 end