Include basic pre-commit hook set

- Good standard to apply for formatting
- The white-space fixer
	- Also apply formatting to existing files
- Json validity checker
- Ensure line endings are `lf` for consistency
- Prevent accidental upload of large files
- Ensure files end with newline

Author: TheOneFromNorway

.github/workflows/destroy-infrastructure.yml

@@ -50,7 +50,7 @@ jobs:
             CLUSTER_IDENTIFIER=$(grep -oP 'db_cluster\s*=\s*"\K[^"]+' env/${{ inputs.environment }}.tfvars)
             aws rds modify-db-cluster --db-cluster-identifier "$CLUSTER_IDENTIFIER" --no-deletion-protection
             echo "DB cluster delete protection removed: proceeding to delete stage"
-          else 
+          else
             echo "DB cluster not in state: proceeding to delete stage"
           fi
 

.github/workflows/lint.yml

@@ -106,3 +106,5 @@ jobs:
           cache: yarn
       - run: yarn install --immutable --immutable-cache --check-cache
       - uses: pre-commit/action@v3.0.1
+        with:
+          extra_args: "--all-files --hook=manual"

.pre-commit-config.yaml

@@ -4,6 +4,18 @@ repos:
     hooks:
       - id: terraform_fmt
         files: \.(tf|tfvars|hcl)$
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: trailing-whitespace
+        exclude: \.(enc|erb)$
+      - id: end-of-file-fixer
+        exclude: \.(enc|erb|csv|svg|rladr)$
+      - id: check-json
+      - id: check-added-large-files # Default is fail on files larger than 500kB
+      - id: mixed-line-ending
+        args: [--fix=lf] # Ensure all line endings are LF
+        exclude: \.csv$
   - repo: local
     hooks:
       - id: prettier

app/components/app_activity_log_component.rb

@@ -7,7 +7,7 @@ class AppActivityLogComponent < ViewComponent::Base
                  nhsuk-u-font-weight-normal">
         <%= day.to_fs(:long) %>
       </h2>
-    
+
       <% events.each do |event| %>
         <%= render AppLogEventComponent.new(card: true, **event) %>
       <% end %>

app/components/app_compare_consent_form_and_patient_component.rb

@@ -9,7 +9,7 @@ class AppCompareConsentFormAndPatientComponent < ViewComponent::Base
           <%= govuk_summary_list(rows: consent_form_rows) %>
         <% end %>
       </div>
-    
+
       <div class="nhsuk-grid-column-one-half nhsuk-card-group__item">
         <%= render AppCardComponent.new(colour: "blue") do |card| %>
           <% card.with_heading { "Child record" } %>

app/components/app_log_event_component.rb

@@ -9,21 +9,21 @@ class AppLogEventComponent < ViewComponent::Base
     <h3 class="<% if card %>nhsuk-card__heading <% end %>nhsuk-heading-s">
       <%= invalidated ? tag.s(title) : title %>
     </h3>
-    
+
     <% if body.present? %>
       <blockquote><p>
         <%= invalidated ? tag.s(body) : body %>
       </p></blockquote>
     <% end %>
-    
+
     <p class="nhsuk-body-s nhsuk-u-margin-0 nhsuk-u-secondary-text-color">
       <% if programmes.any? %>
         <%= render AppProgrammeTagsComponent.new(programmes) %>
         &nbsp;
       <% end %>
       <%= invalidated ? tag.s(subtitle) : subtitle %>
     </p>
-    
+
     <% if card %>
       </div></div>
     <% end %>

app/components/app_patient_card_component.rb

@@ -10,13 +10,13 @@ class AppPatientCardComponent < ViewComponent::Base
           text: "Record updated with child’s date of death"
         ) %>
       <% end %>
-      
+
       <% if patient.invalidated? %>
         <%= render AppStatusComponent.new(
           text: "Record flagged as invalid"
         ) %>
       <% end %>
-      
+
       <% if patient.restricted? %>
         <%= render AppStatusComponent.new(
           text: "Record flagged as sensitive"
@@ -30,7 +30,7 @@ class AppPatientCardComponent < ViewComponent::Base
           <h3 class="nhsuk-heading-s nhsuk-u-margin-bottom-2">
             <%= parent_relationship.label_with_parent %>
           </h3>
-  
+
           <%= render AppParentSummaryComponent.new(parent_relationship:) %>
         <% end %>
       <% end %>

app/components/app_patient_session_search_result_card_component.rb

@@ -15,7 +15,7 @@ class AppPatientSessionSearchResultCardComponent < ViewComponent::Base
               row.with_key { "Year group" }
               row.with_value { helpers.patient_year_group(patient) }
             end
-            
+
             if action_required
               summary_list.with_row do |row|
                 row.with_key { "Action required" }
@@ -30,7 +30,7 @@ class AppPatientSessionSearchResultCardComponent < ViewComponent::Base
               end
             end
           end %>
-      
+
       <% if context == :register && can_register_attendance? %>
         <div class="app-button-group">
           <%= helpers.govuk_button_to "Attending", create_session_register_path(session, patient, "present", search_form: params[:search_form]&.permit!), class: "app-button--secondary app-button--small" %>

app/components/app_patient_session_table_component.rb

@@ -11,7 +11,7 @@ class AppPatientSessionTableComponent < ViewComponent::Base
             <% row.with_cell(text: "Programme") %>
           <% end %>
         <% end %>
-    
+
         <% table.with_body do |body| %>
           <% patient_sessions.each do |patient_session| %>
             <% patient_session.programmes.each do |programme| %>
@@ -21,7 +21,7 @@ class AppPatientSessionTableComponent < ViewComponent::Base
                   <%= link_to patient_session.session.location.name,
                               session_patient_programme_path(patient_session.session, patient_session.patient, programme) %>
                 <% end %>
-      
+
                 <% row.with_cell do %>
                   <span class="nhsuk-table-responsive__heading">Session dates</span>
                   <ul class="nhsuk-list app-list--spaced">
@@ -30,7 +30,7 @@ class AppPatientSessionTableComponent < ViewComponent::Base
                     <% end %>
                   </ul>
                 <% end %>
-      
+
                 <% row.with_cell do %>
                   <span class="nhsuk-table-responsive__heading">Programme</span>
                   <%= render AppProgrammeTagsComponent.new([programme]) %>

app/components/app_search_component.rb

@@ -11,15 +11,15 @@ class AppSearchComponent < ViewComponent::Base
                                  label: { text: "Search", class: "nhsuk-u-visually-hidden" },
                                  autocomplete: "off",
                                  class: "app-search-input__input" %>
-    
+
           <button class="nhsuk-button nhsuk-button--secondary app-button--icon app-search-input__submit" data-module="nhsuk-button" type="submit">
             <svg class="nhsuk-icon nhsuk-icon__search" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" focusable="false" role="img">
               <title>Search</title>
               <path d="M19.71 18.29l-4.11-4.1a7 7 0 1 0-1.41 1.41l4.1 4.11a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42zM5 10a5 5 0 1 1 5 5 5 5 0 0 1-5-5z" fill="currentColor"></path>
             </svg>
           </button>
         </div>
-        
+
         <% if consent_statuses.any? %>
           <%= f.govuk_radio_buttons_fieldset :consent_status, legend: { text: "Consent status", size: "s" } do %>
             <%= f.govuk_radio_button :consent_status, "", label: { text: "Any" } %>
@@ -28,7 +28,7 @@ class AppSearchComponent < ViewComponent::Base
             <% end %>
           <% end %>
         <% end %>
-        
+
         <% if triage_statuses.any? %>
           <%= f.govuk_radio_buttons_fieldset :triage_status, legend: { text: "Triage outcome", size: "s" } do %>
             <%= f.govuk_radio_button :triage_status, "", label: { text: "Any" } %>
@@ -37,7 +37,7 @@ class AppSearchComponent < ViewComponent::Base
             <% end %>
           <% end %>
         <% end %>
-        
+
         <% if register_statuses.any? %>
           <%= f.govuk_radio_buttons_fieldset :register_status, legend: { text: "Registration status", size: "s" } do %>
             <%= f.govuk_radio_button :register_status, "", label: { text: "Any" } %>
@@ -46,7 +46,7 @@ class AppSearchComponent < ViewComponent::Base
             <% end %>
           <% end %>
         <% end %>
-        
+
         <% if session_statuses.any? %>
           <%= f.govuk_radio_buttons_fieldset :session_status, legend: { text: "Vaccination status", size: "s" } do %>
             <%= f.govuk_radio_button :session_status, "", label: { text: "Any" } %>
@@ -55,7 +55,7 @@ class AppSearchComponent < ViewComponent::Base
             <% end %>
           <% end %>
         <% end %>
-        
+
         <% if programme_statuses.any? %>
           <%= f.govuk_radio_buttons_fieldset :programme_status, legend: { text: "Programme outcome", size: "s" } do %>
             <%= f.govuk_radio_button :programme_status, "", label: { text: "Any" } %>