Remove PatientSession#todays_attendance

It's specific to the session so we need to move it out of this model so
it can be used when we no longer have an explicit link to the session.

Jira-Issue: MAV-1938

Author: thomasleese

app/controllers/sessions/register_controller.rb

@@ -5,8 +5,8 @@ class Sessions::RegisterController < ApplicationController
 
   before_action :set_session
   before_action :set_patient_search_form, only: :show
+  before_action :set_session_date, only: :create
   before_action :set_patient, only: :create
-  before_action :set_patient_session, only: :create
 
   layout "full"
 
@@ -27,13 +27,17 @@ def show
   def create
     attendance_record =
       ActiveRecord::Base.transaction do
-        record = authorize @patient_session.todays_attendance
+        record =
+          authorize @patient
+                      .attendance_records
+                      .includes(:session_date)
+                      .find_or_initialize_by(session_date: @session_date)
         record.update!(attending: params[:status] == "present")
-        StatusUpdater.call(patient: @patient_session.patient)
+        StatusUpdater.call(patient: @patient)
         record
       end
 
-    name = @patient_session.patient.full_name
+    name = @patient.full_name
 
     flash[:info] = if attendance_record.attending?
       t("attendance_flash.present", name:)
@@ -50,12 +54,11 @@ def set_session
     @session = policy_scope(Session).find_by!(slug: params[:session_slug])
   end
 
-  def set_patient
-    @patient = policy_scope(Patient).find(params[:patient_id])
+  def set_session_date
+    @session_date = @session.session_dates.find_by!(value: Date.current)
   end
 
-  def set_patient_session
-    @patient_session =
-      PatientSession.find_by!(patient: @patient, session: @session)
+  def set_patient
+    @patient = policy_scope(Patient).find(params[:patient_id])
   end
 end

app/models/patient_session.rb

@@ -321,15 +321,6 @@ def destroy_if_safe!
 
   def programmes = session.programmes_for(patient:, academic_year:)
 
-  def todays_attendance
-    if (session_date = session.session_dates.today.first)
-      patient
-        .attendance_records
-        .includes(:patient, session_date: { session: :programmes })
-        .find_or_initialize_by(session_date:)
-    end
-  end
-
   def next_activity(programme:)
     if patient.vaccination_status(programme:, academic_year:).vaccinated?
       return nil

app/views/patient_sessions/_header.html.erb

@@ -38,7 +38,9 @@
     </li>
   <% end %>
 
-  <% if @session.requires_registration? && (attendance_record = @patient_session.todays_attendance) %>
+  <% if @session.requires_registration? && (session_date = @session.session_dates.today.first) %>
+    <% attendance_record = @patient.attendance_records.includes(:session_date).find_or_initialize_by(session_date:) %>
+
     <li class="app-action-list__item">
       <%= render AppStatusTagComponent.new(@patient_session.registration_status&.status || "unknown", context: :register) %>
     </li>