also make event_timestamp_day/month/year not null, and populate essential fields in the factory

Author: Alistair Davidson

app/models/reporting_api/vaccination_event.rb

@@ -6,10 +6,10 @@
 #
 #  id                                               :bigint           not null, primary key
 #  event_timestamp                                  :datetime         not null
-#  event_timestamp_academic_year                    :integer
-#  event_timestamp_day                              :integer
-#  event_timestamp_month                            :integer
-#  event_timestamp_year                             :integer
+#  event_timestamp_academic_year                    :integer          not null
+#  event_timestamp_day                              :integer          not null
+#  event_timestamp_month                            :integer          not null
+#  event_timestamp_year                             :integer          not null
 #  event_type                                       :string           not null
 #  location_address_postcode                        :string
 #  location_address_town                            :string

db/migrate/20250827100519_add_reporting_api_vaccination_events.rb

@@ -5,10 +5,10 @@ def change
     create_table :reporting_api_vaccination_events do |t|
       t.string :event_type, null: false
       t.datetime :event_timestamp, null: false
-      t.integer :event_timestamp_year
-      t.integer :event_timestamp_month
-      t.integer :event_timestamp_day
-      t.integer :event_timestamp_academic_year
+      t.integer :event_timestamp_year, null: false
+      t.integer :event_timestamp_month, null: false
+      t.integer :event_timestamp_day, null: false
+      t.integer :event_timestamp_academic_year, null: false
 
       t.references :source, polymorphic: true
 

db/schema.rb

@@ -826,10 +826,10 @@
   create_table "reporting_api_vaccination_events", force: :cascade do |t|
     t.string "event_type", null: false
     t.datetime "event_timestamp", null: false
-    t.integer "event_timestamp_year"
-    t.integer "event_timestamp_month"
-    t.integer "event_timestamp_day"
-    t.integer "event_timestamp_academic_year"
+    t.integer "event_timestamp_year", null: false
+    t.integer "event_timestamp_month", null: false
+    t.integer "event_timestamp_day", null: false
+    t.integer "event_timestamp_academic_year", null: false
     t.string "source_type"
     t.bigint "source_id"
     t.bigint "patient_id", null: false

spec/factories/reporting_api_vaccination_events.rb

@@ -6,10 +6,10 @@
 #
 #  id                                               :bigint           not null, primary key
 #  event_timestamp                                  :datetime         not null
-#  event_timestamp_academic_year                    :integer
-#  event_timestamp_day                              :integer
-#  event_timestamp_month                            :integer
-#  event_timestamp_year                             :integer
+#  event_timestamp_academic_year                    :integer          not null
+#  event_timestamp_day                              :integer          not null
+#  event_timestamp_month                            :integer          not null
+#  event_timestamp_year                             :integer          not null
 #  event_type                                       :string           not null
 #  location_address_postcode                        :string
 #  location_address_town                            :string
@@ -79,6 +79,7 @@
       session { build(:session, location: location) }
     end
 
+    event_type { outcome }
     source do
       build(
         :vaccination_record,
@@ -90,6 +91,7 @@
         performed_by: User.first
       )
     end
+    event_timestamp { source.performed_at }
     patient { for_patient }
     vaccination_record_outcome { outcome }
     patient_year_group { year_group }

spec/models/reporting_api/vaccination_event_spec.rb

@@ -6,10 +6,10 @@
 #
 #  id                                               :bigint           not null, primary key
 #  event_timestamp                                  :datetime         not null
-#  event_timestamp_academic_year                    :integer
-#  event_timestamp_day                              :integer
-#  event_timestamp_month                            :integer
-#  event_timestamp_year                             :integer
+#  event_timestamp_academic_year                    :integer          not null
+#  event_timestamp_day                              :integer          not null
+#  event_timestamp_month                            :integer          not null
+#  event_timestamp_year                             :integer          not null
 #  event_type                                       :string           not null
 #  location_address_postcode                        :string
 #  location_address_town                            :string