Merge pull request #4231 from nhsuk/improve-destroy-endpoint

Improve team destruction endpoint

Author: thomasleese

app/controllers/api/testing/teams_controller.rb

@@ -34,13 +34,16 @@ def destroy
 
         log_destroy(SessionDate.where(session: sessions))
 
-        log_destroy(SchoolMove.where(patient_id: patient_ids))
-        log_destroy(SchoolMove.where(team:))
-        log_destroy(SchoolMoveLogEntry.where(patient_id: patient_ids))
         log_destroy(AccessLogEntry.where(patient_id: patient_ids))
-        log_destroy(NotifyLogEntry.where(patient_id: patient_ids))
+        log_destroy(ArchiveReason.where(patient_id: patient_ids))
+        log_destroy(ConsentNotification.where(patient_id: patient_ids))
+        log_destroy(Note.where(patient_id: patient_ids))
         # In local dev we can end up with NotifyLogEntries without a patient
         log_destroy(NotifyLogEntry.where(patient_id: nil))
+        log_destroy(NotifyLogEntry.where(patient_id: patient_ids))
+        log_destroy(SchoolMove.where(patient_id: patient_ids))
+        log_destroy(SchoolMove.where(team:))
+        log_destroy(SchoolMoveLogEntry.where(patient_id: patient_ids))
         log_destroy(VaccinationRecord.where(patient_id: patient_ids))
 
         log_destroy(ConsentForm.where(team:))