Remove schools move export feature flag (#3401)

This feature is ready to be enabled for all users so we can remove the
feature flag.

Author: thomasleese

app/views/school_moves/index.html.erb

@@ -1,16 +1,14 @@
 <%= h1 "School moves", size: "xl" %>
 
-<% if Flipper.enabled?(:school_moves_export) %>
-  <div class="nhsuk-grid-row">
-    <div class="nhsuk-grid-column-two-thirds">
-      <p>When imported records or a new consent response indicates that a child has changed
-        school, Mavis flags this as a school move.</p>
-      <p>You can then review the new information and confirm the school move or ignore it.</p>
+<div class="nhsuk-grid-row">
+  <div class="nhsuk-grid-column-two-thirds">
+    <p>When imported records or a new consent response indicates that a child has changed
+      school, Mavis flags this as a school move.</p>
+    <p>You can then review the new information and confirm the school move or ignore it.</p>
 
-      <%= govuk_button_to "Download records", school_move_exports_path, class: "app-button--secondary nhsuk-u-margin-bottom-5" %>
-    </div>
+    <%= govuk_button_to "Download records", school_move_exports_path, class: "app-button--secondary nhsuk-u-margin-bottom-5" %>
   </div>
-<% end %>
+</div>
 
 <% if @school_moves.any? %>
   <div class="nhsuk-table__panel-with-heading-tab">

config/feature_flags.yml

@@ -9,5 +9,3 @@ offline_working: Prototype support for using Mavis offline.
 
 report_gillick_notify_parents: Include whether patients would like their
   parents to be informed of vaccinations in the reporting.
-
-school_moves_export: Allow exporting confirmed school moves.

spec/features/download_school_moves_spec.rb

@@ -1,9 +1,6 @@
 # frozen_string_literal: true
 
 describe "Download school moves" do
-  before { Flipper.enable(:school_moves_export) }
-  after { Flipper.disable(:school_moves_export) }
-
   scenario "no dates given" do
     given_i_am_signed_in
     and_school_moves_exist