Merge pull request #4334 from nhsuk/fix-header

Fix header role description

Author: thomasleese

app/models/user.rb

@@ -121,6 +121,16 @@ def role_name
     cis2_info.role_name if cis2_enabled?
   end
 
+  def role_description
+    role = (can_prescribe_pgd? ? "Nurse" : "Administrator")
+
+    if can_access_sensitive_records? || can_perform_local_admin_tasks?
+      "#{role} (Superuser)"
+    else
+      role
+    end
+  end
+
   def can_view?
     cis2_enabled? ? cis2_info.can_view? : !fallback_role.nil?
   end

app/views/layouts/_header.html.erb

@@ -23,7 +23,7 @@
               <svg class="app-header__account-icon" xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 16 16" aria-hidden="true" focusable="false">
                 <path fill="currentColor" d="M8 0c4.4 0 8 3.6 8 8s-3.6 8-8 8-8-3.6-8-8 3.6-8 8-8Zm0 1a7 7 0 1 0 0 14A7 7 0 0 0 8 1Zm-1.5 9h3a2.5 2.5 0 0 1 2.5 2.5V14a1 1 0 0 1-1 1H5a1 1 0 0 1-1-1v-1.5A2.5 2.5 0 0 1 6.5 10ZM8 9C6.368 9 5 7.684 5 6s1.316-3 3-3c1.632 0 3 1.316 3 3S9.632 9 8 9"></path>
               </svg>
-              <%= current_user.full_name %> <%= (role_name = current_user.role_name) ? " (#{role_name})" : "" %>
+              <%= current_user.full_name %> <%= (role_description = current_user.role_description) ? " (#{role_description})" : "" %>
             </span>
             <% if Settings.cis2.enabled %>
               <span class="app-header__account-item">

spec/models/user_spec.rb

@@ -53,6 +53,28 @@
     end
   end
 
+  describe "#role_description" do
+    subject { user.role_description }
+
+    context "when the user is an admin" do
+      let(:user) { build(:admin) }
+
+      it { should eq("Administrator") }
+    end
+
+    context "when the user is a nurse" do
+      let(:user) { build(:nurse) }
+
+      it { should eq("Nurse") }
+    end
+
+    context "when the user is a superuser" do
+      let(:user) { build(:admin, :superuser) }
+
+      it { should eq("Administrator (Superuser)") }
+    end
+  end
+
   describe "#can_view?" do
     subject { user.can_view? }