Remove health_answers_require_follow_up column

This removes the column from the `Patient::ConsentStatus` model as it's
no longer being used. Instead, the triage status is calculated using the
values from the consent directly meaning the consent status and triage
status can be updated independently.

Author: thomasleese

app/lib/status_updater.rb

@@ -40,7 +40,7 @@ def update_consent_statuses!
           batch,
           on_duplicate_key_update: {
             conflict_target: [:id],
-            columns: %i[health_answers_require_follow_up status]
+            columns: %i[status]
           }
         )
       end

app/models/patient/consent_status.rb

@@ -4,11 +4,10 @@
 #
 # Table name: patient_consent_statuses
 #
-#  id                               :bigint           not null, primary key
-#  health_answers_require_follow_up :boolean          default(FALSE), not null
-#  status                           :integer          default("no_response"), not null
-#  patient_id                       :bigint           not null
-#  programme_id                     :bigint           not null
+#  id           :bigint           not null, primary key
+#  status       :integer          default("no_response"), not null
+#  patient_id   :bigint           not null
+#  programme_id :bigint           not null
 #
 # Indexes
 #
@@ -41,9 +40,6 @@ class Patient::ConsentStatus < ApplicationRecord
         -> { where("patient_id = patient_sessions.patient_id") }
 
   def assign_status
-    self.health_answers_require_follow_up =
-      latest_consents.any?(&:health_answers_require_follow_up?)
-
     self.status =
       if status_should_be_given?
         :given

db/migrate/20250324191759_remove_health_answers_require_follow_up_from_patient_consent_status.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class RemoveHealthAnswersRequireFollowUpFromPatientConsentStatus < ActiveRecord::Migration[
+  8.0
+]
+  def change
+    remove_column :patient_consent_statuses,
+                  :health_answers_require_follow_up,
+                  :boolean,
+                  default: false,
+                  null: false
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.0].define(version: 2025_03_24_063136) do
+ActiveRecord::Schema[8.0].define(version: 2025_03_24_191759) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_catalog.plpgsql"
   enable_extension "pg_trgm"
@@ -551,7 +551,6 @@
     t.bigint "patient_id", null: false
     t.bigint "programme_id", null: false
     t.integer "status", default: 0, null: false
-    t.boolean "health_answers_require_follow_up", default: false, null: false
     t.index ["patient_id", "programme_id"], name: "index_patient_consent_statuses_on_patient_id_and_programme_id", unique: true
     t.index ["patient_id"], name: "index_patient_consent_statuses_on_patient_id"
     t.index ["programme_id"], name: "index_patient_consent_statuses_on_programme_id"

spec/factories/patient_consent_statuses.rb

@@ -4,11 +4,10 @@
 #
 # Table name: patient_consent_statuses
 #
-#  id                               :bigint           not null, primary key
-#  health_answers_require_follow_up :boolean          default(FALSE), not null
-#  status                           :integer          default("no_response"), not null
-#  patient_id                       :bigint           not null
-#  programme_id                     :bigint           not null
+#  id           :bigint           not null, primary key
+#  status       :integer          default("no_response"), not null
+#  patient_id   :bigint           not null
+#  programme_id :bigint           not null
 #
 # Indexes
 #
@@ -28,9 +27,5 @@
     programme
 
     traits_for_enum :status
-
-    trait :health_answers_require_follow_up do
-      health_answers_require_follow_up { true }
-    end
   end
 end

spec/factories/patients.rb

@@ -276,7 +276,6 @@
           association(
             :patient_consent_status,
             :given,
-            :health_answers_require_follow_up,
             patient: instance,
             programme:
           )

spec/models/patient/consent_status_spec.rb

@@ -4,11 +4,10 @@
 #
 # Table name: patient_consent_statuses
 #
-#  id                               :bigint           not null, primary key
-#  health_answers_require_follow_up :boolean          default(FALSE), not null
-#  status                           :integer          default("no_response"), not null
-#  patient_id                       :bigint           not null
-#  programme_id                     :bigint           not null
+#  id           :bigint           not null, primary key
+#  status       :integer          default("no_response"), not null
+#  patient_id   :bigint           not null
+#  programme_id :bigint           not null
 #
 # Indexes
 #
@@ -132,37 +131,4 @@
       end
     end
   end
-
-  describe "#health_answers_require_follow_up" do
-    subject do
-      patient_consent_status.assign_status
-      patient_consent_status.health_answers_require_follow_up
-    end
-
-    before { patient.strict_loading!(false) }
-
-    context "with no consent" do
-      it { should be(false) }
-    end
-
-    context "with an invalidated consent with health answers" do
-      before do
-        create(
-          :consent,
-          :invalidated,
-          :health_question_notes,
-          patient:,
-          programme:
-        )
-      end
-
-      it { should be(false) }
-    end
-
-    context "with a consent with health answers" do
-      before { create(:consent, :health_question_notes, patient:, programme:) }
-
-      it { should be(true) }
-    end
-  end
 end