Log PDS returned NHS number

Author: Lakshmi Murugappan

lib/pds_experiments/pds_experiment_analyzer.rb

@@ -8,6 +8,7 @@ class PDSExperimentAnalyzer
       no_results
       too_many_matches_errors
       other_errors
+      nhs_numbers_returned
       nhs_number_discrepancies
       nhs_number_discrepancy_ids
       nhs_number_discrepancy_patients
@@ -53,6 +54,7 @@ def analyze
         no_results: counters["no_results"] || 0,
         too_many_matches_errors: counters["too_many_matches_errors"] || 0,
         other_errors: counters["other_errors"] || 0,
+        nhs_numbers_returned: counters["nhs_numbers_returned"] || [],
         nhs_number_discrepancies: counters["nhs_number_discrepancies"] || 0,
         family_name_discrepancies: counters["family_name_discrepancies"] || 0,
         date_of_birth_discrepancies:

lib/pds_experiments/pds_experiment_job.rb

@@ -32,6 +32,8 @@ def perform(patient, experiment_name)
       if pds_patient
         increment_counter(experiment_name, "successful_lookups")
 
+        store_nhs_number(experiment_name, patient, pds_patient)
+
         if patient.nhs_number.present? &&
              patient.nhs_number != pds_patient.nhs_number
           increment_counter(experiment_name, "nhs_number_discrepancies")
@@ -195,6 +197,19 @@ def store_nhs_discrepancy(experiment_name, patient, pds_patient)
       Rails.cache.write(discrepancy_key, discrepancies, expires_in: 7.days)
     end
 
+    def store_nhs_number(experiment_name, patient, pds_patient)
+      discrepancy_key = "pds_experiment:#{experiment_name}:nhs_numbers_returned"
+      discrepancies = Rails.cache.read(discrepancy_key) || []
+
+      discrepancies << {
+        patient_id: patient.id,
+        patient_nhs: patient.nhs_number || "",
+        pds_nhs: pds_patient.nhs_number
+      }
+
+      Rails.cache.write(discrepancy_key, discrepancies, expires_in: 7.days)
+    end
+
     def store_array_of_ids(experiment_name, array_name, patient_id)
       request_key = "pds_experiment:#{experiment_name}:#{array_name}"
       requests = Rails.cache.read(request_key) || []