Introduce imms_api_search_job

- This mostly replaces `immunisations_fhir_api_integration_search`, but has a slightly different meaning; it is instead used only to restrict the automated jobs which trigger the search requests, rather than blocking the search requests themselves.
- This allows the CLI tools to be used without this feature flag being enabled, allowing operational use without the automated searching. The CLI tools are still restricted by `imms_api_integration`.

Author: alistair-white-horne-tng

app/lib/mavis_cli/vaccination_records/create_from_fhir.rb

@@ -24,11 +24,6 @@ class CreateFromFHIR < Dry::CLI::Command
       def call(patient_id:, team_id: nil, file: nil, json: nil, **)
         MavisCLI.load_rails
 
-        unless Flipper.enabled?(:immunisations_fhir_api_integration_search)
-          puts "Error: Feature flag :immunisations_fhir_api_integration_search is not enabled"
-          return
-        end
-
         unless Flipper.enabled?(:imms_api_integration)
           puts "Error: Feature flag :imms_api_integration is not enabled"
           return

app/lib/mavis_cli/vaccination_records/search_imms_api.rb

@@ -27,8 +27,7 @@ def call(
         MavisCLI.load_rails
 
         unless Flipper.enabled?(:imms_api_integration)
-          puts "Cannot search: one of the feature flags is disabled " \
-                 "(immunisations_fhir_api_integration, immunisations_fhir_api_integration_search)"
+          puts "Cannot search: Feature flag :imms_api_integration is not enabled"
           return
         end
 

app/lib/nhs/immunisations_api.rb

@@ -216,8 +216,7 @@ def should_be_in_immunisations_api?(
     end
 
     def search_immunisations(patient, programmes:, date_from: nil, date_to: nil)
-      unless Flipper.enabled?(:imms_api_integration) &&
-               Flipper.enabled?(:immunisations_fhir_api_integration_search)
+      unless Flipper.enabled?(:imms_api_integration)
         Rails.logger.info(
           "Not searching for vaccination records in the immunisations API as the" \
             "feature flag is disabled: Patient #{patient.id}"

config/feature_flags.yml

@@ -8,8 +8,8 @@ dev_tools: Developer tools useful for testing and debugging.
 
 imms_api_integration: Umbrella flag to switch off ALL API integration (including CLI tools).
 
-immunisations_fhir_api_integration_search: Master switch to control whether
-  search requests can be made to the NHS Immunisations FHIR API.
+imms_api_search_job: Flag to switch off any automated receipt of vaccination records (Read, Search),
+  via scheduled jobs.
 
 imms_api_sync_job: Flag to switch off any automated sending of vaccination records
   (Create, Update, Delete), triggered by the creation/edit/delete of any vaccination records.

spec/lib/nhs/immunisations_api_spec.rb

@@ -1,10 +1,7 @@
 # frozen_string_literal: true
 
 describe NHS::ImmunisationsAPI do
-  before do
-    Flipper.enable(:immunisations_fhir_api_integration_search)
-    Flipper.enable(:imms_api_integration)
-  end
+  before { Flipper.enable(:imms_api_integration) }
 
   let(:team) { create(:team, ods_code: "A9A5A") }
   let(:patient) do
@@ -58,18 +55,6 @@
   end
   let(:notify_parents) { true }
 
-  shared_examples "an immunisations_fhir_api_integration_search feature flag check" do
-    context "the immunisations_fhir_api_integration_search feature flag is disabled" do
-      before { Flipper.disable(:immunisations_fhir_api_integration_search) }
-
-      it "does not make a request to the NHS API" do
-        perform_request
-
-        expect(request_stub).not_to have_been_made
-      end
-    end
-  end
-
   shared_examples "an imms_api_integration feature flag check" do
     context "the imms_api_integration feature flag is disabled" do
       before { Flipper.disable(:imms_api_integration) }
@@ -770,7 +755,6 @@
     include_examples "generic error handling"
     include_examples "unexpected response status", 250, "searching"
 
-    include_examples "an immunisations_fhir_api_integration_search feature flag check"
     include_examples "an imms_api_integration feature flag check"
   end
 end