Track DPS exports sent with MESH #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
previously approved these changes
Aug 14, 2024
This will be used to determine if a file send via MESH has been accepted by the receiver or not, e.g. DPS.
misaka
force-pushed
the
mesh-track
branch
2 times, most recently
from
76790cf to
fa5c702
Compare
This mirrors the status we get back from MESH, making it easier to understand the status of a dps export.
Ignoring the caps-gore, this aligns with the rest of the MESH jobs, and since DPS is MESH-based for the foreseeable future, this makes sense.
|
misaka
changed the title
misaka
dismissed
thomasleese’s stale review
Much has changed so it warrants a re-review.
thomasleese
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tracking of the DPS exports sent via MESH. A few specific topics that might be worthy of commentary are:
MESH.track_messagewhich returnFaraday::Responseobjects. On one hand, I'd like it if theMESHlibrary functions would re-wrap these responses to abstract them out for the caller, otoh it's quite convenient to just get these in the Rake task and to inspect them there.MESHDPSExportsJobis a bit fugly, but I thinkMESHis better thanMesh, so I think I still prefer it overMeshDpsExportsJob. Does anyone have a strong opinion / argument otherwise?