Fix school importer #1635
Merged
Fix school importer #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the import breaks if it encounters validation errors.
The GIAS CSV contains some school addresses that don't have a protocol. As such, they are not valid URLs according to validate_url. To work around this, we can force prepend `https://`, which assumes that the school websites have HTTPS setup. This isn't a given, but it feels like the better default, since HTTPS is pretty strongly pushed by browser vendors. The URL for Legh Vale Primary School is also plainly malformed and starts with `http:www`. It's the only instance of this, but we have to work around it.
thomasleese
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
import!which causes the import to fail if any locations don't pass validations.The GIAS CSV contains some school addresses that don't have a protocol. As such, they are not valid URLs according to validate_url.
To work around this, we can force prepend
https://, which assumes that the school websites have HTTPS setup. This isn't a given, but it feels like the better default, since HTTPS is pretty strongly pushed by browser vendors.The URL for Legh Vale Primary School is also malformed and starts with
http:www. It's the only instance of this, but we have to work around it.