Show immunisation import statistics #1673
Conversation
This allows us to store the count statistics related to immunisation imports so they can be displayed to the user.
This updates the import process to ensure that we capture the statistics and store them on the immunisation imports.
thomasleese
force-pushed
the
immunisation-import-stats
branch
from
a1a8045 to
5a6d002
Compare
If there are duplicate records or not administered records, we want to include this information in a warning callout at the top of the page. The warning callout component is part of the NHS design system, but not part of GOV.UK's so we don't have a component in govuk-components for it. As this is the first time we're using it, I decided against creating a component for it, but we might want to do add one in the future.
thomasleese
force-pushed
the
immunisation-import-stats
branch
from
5a6d002 to
a6b9278
Compare
|
| errors.add(column, :blank) if send(column).nil? | ||
| end | ||
| else | ||
| COUNT_COLUMNS.each do |column| |
There was a problem hiding this comment.
When would this path ever be taken? Do we really need to account for it?
There was a problem hiding this comment.
Yeah I was in two minds about whether it was worth doing, I put it in because it is a requirement for the stats to have been calculated if it's processed, but you're right that there's only one code paths which processes these. I figured there was no harm in having it in there, and best case it'll spot perhaps a manual update to the records in the future.
There was a problem hiding this comment.
Would it make sense to use something that would raise here? That would give us an alert in Sentry which might be a clearer indication of our intention here.
But ¯\_(ツ)_/¯ ... 
first
If there are duplicate records or not administered records, we want to include this information in a warning callout at the top of the page.
The warning callout component is part of the NHS design system, but not part of GOV.UK's so we don't have a component in govuk-components for it. As this is the first time we're using it, I decided against creating a component for it, but we might want to do add one in the future.
Screenshots