Add ability to edit campaigns #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
edit-campaign
branch
from
ff2beaa to
dae446a
Compare
tvararu
approved these changes
Sep 4, 2024
This is being renamed to `Campaigns::EditController` as it'll be used both for creating new campaigns (i.e. from draft to active) and editing existing (i.e. active) campaigns.
This simplifies the validation on the campaign model to rely entirely on the `on_wizard_step` validation options like all the other models. The behaviour should be the same before and after.
This makes a number of small changes to the tests to support them being used in the future to also test the edit campaign journey.
This adds a link to the campaign overview page that allows the user to make changes to the campaign.
When creating a new campaign we don't show the vaccines as they are picked automatically, but when editing an existing campaign we would want to be able to change the vaccines, perhaps to add any discontinued ones.
This adds the ability to change the existing information on a campaign, using the same controller that we have for creating new campaigns. This is built by adding "Change" links to the summary list for the campaign, and ensuring we skip straight to the confirmation step rather than the next step.
This adds a new step for editing campaigns where the user can choose the vaccines that belong to a campaign. When creating a campaign the vaccines default to the active vaccines for a particular programme type, but we may need to add discontinued vaccines to campaigns that happened in the past, to support importing historical records.
thomasleese
force-pushed
the
edit-campaign
branch
from
dae446a to
c0b51af
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to edit existing campaigns, using most of the same logic and UI as when new campaigns are created, but adding an additional step for modifying the vaccines.
Screenshots