Skip to content

Minor fixes to immunisation import error reporting #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasleese merged 2 commits into from
Sep 4, 2024
Merged

Minor fixes to immunisation import error reporting #1702

thomasleese merged 2 commits into from
Sep 4, 2024

Conversation

@thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 3, 2024

This fixes a number of issues that were broken in ae6f10d by ensuring the errors remain attached to the right form field.

@thomasleese thomasleese requested a review from a team as a code owner September 3, 2024 14:59
@thomasleese
Ensure immunisation import CSV is encrypted
f23fcdc 
This should have been working but was accidentally broken in ae6f10d.
@thomasleese
Ensure immunisation import validations show correctly
7e3b287 
In ae6f10d we split up the `csv` attribute in to `csv_data` and
`csv_filename`, but since the form field is called `csv` we need to
ensure that validation errors remain attached to a `csv` field.
@thomasleese thomasleese force-pushed the immunisation-import-csv branch from aa7018b to 7e3b287 Compare September 4, 2024 09:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tvararu tvararu temporarily deployed to mavis-pr-1702 September 4, 2024 09:30 Inactive
@thomasleese thomasleese merged commit 211660b into main Sep 4, 2024
@thomasleese thomasleese deleted the immunisation-import-csv branch September 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvararu tvararu tvararu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasleese @tvararu