Refactor models related to CSV imports #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
refactor-cohort-list
branch
from
69420f6 to
52aec8f
Compare
thomasleese
force-pushed
the
immunisation-import-csv
branch
from
aa7018b to
7e3b287
Compare
thomasleese
force-pushed
the
refactor-cohort-list
branch
from
52aec8f to
f6daedf
Compare
tvararu
approved these changes
Sep 4, 2024
These models are very similar so by aligning their functionality we can extract the common code in to a concern.
This adds a concern for models which can be imported from a CSV file which encapsulates the common logic and reduces the duplication. This also helps to ensure that the functionality works the same across the service.
thomasleese
force-pushed
the
refactor-cohort-list
branch
from
f6daedf to
d6000cb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
ImmunisationImportandCohortListmodels to use a commonCSVImportableconcern which encapsulates the logic of both classes and ensure the behaviour is consistent across the two.