Add draft/active patient sessions #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This column isn't being used anywhere, and we calculate the state of each session dynamically.
This adds a column to patient sessions for tracking which patient sessions are active (i.e. from the import and should be shown in the UI) and draft.
This makes a number of improvements to the patient session factory to use the association feature rather than creating objects explicitly. I've also removed the transiant user property and instead we can be explicit about it being the created_by property.
When first importing immunisations we want the patient sessions to be draft so they don't appear in any parts of the interface, until the import is confirmed and then they are marked as active. Without this, it's possible for a patient to appear in parts of the system if the session already existed (and was active).
Draft patient sessions which may have been imported but not yet confirmed shouldn't be shown anywhere yet.
|
tvararu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the concept of draft/active to patient sessions, to support the immunisation import process. When we import patient sessions, we only want them to be active (and therefore shown in the UI) once the "Check and confirm" step has been completed. Currently this wasn't the case, which lead to patients being shown in the UI before the import had been confirmed.
I've also removed the unused
statecolumn from patient sessions, and made a number of general improvements to the factories.