Refactor PatientSession and associated factories #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
refactor-patient-session-factories
branch
from
4097a56 to
652e735
Compare
thomasleese
force-pushed
the
refactor-patient-session-factories
branch
from
652e735 to
e5eab23
Compare
tvararu
approved these changes
Sep 6, 2024
This refactors the factories related to patient sessions, and therefore sessions and patients too, to simplify their use and improve the code readability. The main changes are automatic creation of patient sessions if a session is passed to the patient when created, which simplifies a number of other factories; and the use of association in the factories.
thomasleese
force-pushed
the
refactor-patient-session-factories
branch
from
e5eab23 to
2085aea
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the factories related to patient sessions, and therefore sessions and patients too, to simplify their use and improve the code readability.
The main changes are automatic creation of patient sessions if a session is passed to the patient when created, which simplifies a number of other factories; and the use of association in the factories.