Skip to content

Conversation

benilovj
Copy link
Contributor

@benilovj benilovj commented Nov 6, 2024

What's the issue?

To reproduce

  1. Find a patient with given consent from a parent
  2. Start recording a Gillick competency assessment
  3. Record that the child isn’t Gillick compentent

Actual

Child’s status is shown as: “Not vaccinated - no-one responded to our requests for consent. When assessed, the child was not Gillick competent.”

This is wrong in a number of ways:

  • A failed Gillick competency assessment shouldn’t override the parent’s consent – it should just be ignored in the determination whether consent is present or not
  • A failed Gillick competency assessment shouldn’t prevent vaccination recording.
  • The message “no-one responded to our requests for consent” is inaccurate, as there’s definitely a consent response from a parent

Expected

Gillick assessment result recorded, child’s vaccination can still be recorded as there is consent available. If there isn't any consent available, the status should remain as "No response".

What's the technical change?

Remove the unable_to_vaccinate_not_gillick_competent state completely.

@benilovj
Copy link
Contributor Author

benilovj commented Nov 6, 2024

Leaving in draft until tomorrow to clarify that I've gotten this right...

@benilovj benilovj marked this pull request as ready for review November 7, 2024 14:43
@benilovj
Copy link
Contributor Author

benilovj commented Nov 7, 2024

Behaviour has been 2i'ed, this PR is ready for review.

A Gillick assessment must be passed in order to record self consent, but it in itself shouldn't affect the patient's state – instead, the presence (or absence) of self-consent should. So the logic that a failed Gillick assessment automatically leads to the child not getting vaccinated isn't quite right
@benilovj benilovj force-pushed the not-being-gillick-competent-should-not-directly-affect-state branch from cc141f0 to c83b5dd Compare November 7, 2024 14:44
@tvararu tvararu temporarily deployed to mavis-pr-2355 November 7, 2024 14:44 Inactive
@benilovj benilovj enabled auto-merge (rebase) November 7, 2024 14:45
Copy link

sonarqubecloud bot commented Nov 7, 2024

@benilovj benilovj merged commit de203fa into main Nov 7, 2024
12 checks passed
@benilovj benilovj deleted the not-being-gillick-competent-should-not-directly-affect-state branch November 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants