Prevent creation of session dates in current academic year #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
session-dates-academic-year
branch
from
3937978 to
ad975be
Compare
tvararu
approved these changes
Nov 11, 2024
When importing immunisations, we now validate that the date of vaccination matches an existing session date if we're importing records for the current academic year rather than creating new session dates. To support this the `location` and `school` method can now be used even if the row doesn't validate (as they're used in this validation).
thomasleese
force-pushed
the
session-dates-academic-year
branch
from
ad975be to
7da8197
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing immunisations, we now validate that the date of vaccination matches an existing session date if we're importing records for the current academic year rather than creating new session dates.
To support this the
locationandschoolmethod can now be used even if the row doesn't validate (as they're used in this validation).