1.1 #2489
Merged
1.1 #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
release-1c
branch
from
05ff65d to
d9d6881
Compare
thomasleese
force-pushed
the
release-1c
branch
from
d9d6881 to
f82237e
Compare
thomasleese
force-pushed
the
release-1c
branch
from
6252ee4 to
d3675c0
Compare
thomasleese
force-pushed
the
release-1c
branch
from
1b889f7 to
88a6d32
Compare
I'm not sure having a separate controller provides us with any benefit here, and combining this with the `ProgrammesController` allows us to re-use the same before actions and keeps the views together in the same directory.
This makes it possible to filter patients by their date of birth when looking at the patients page for a particular programme.
This allows us to use the list of available states in places like the patient filtering.
This allows nurses to filter patients more easily.
Aligns the design to the prototype.
This is unnecessary as we want to create the sessions well before an organisation has any patients, as part of onboarding. This also helps us in preparation for the removal of the `create_patient_sessions!` method as we decouple school moves with session moves.
This adds a scope for getting patients that belong to a particular organisation, so it can be used in multiple places.
thomasleese
force-pushed
the
release-1c
branch
from
bdc2f17 to
e7d6f0f
Compare
Currently we only set this value if the parent indicates that the child's school is different to current location, but I think the code makes more sense if we set it all the time and then we don't need to worry about checking the location or the school.
This consolidates the values of `school` and `home_educated` to use them in a consistent way across the service. This means that there will be three possible combinations of these values: - school present and home_educated nil - school nil and home_educated true - school nil and home_educated false I will add validation in a follow up commit to ensure this is always the case.
This ensures that the combination of these two fields is one of three kinds: - school present and home_educated nil - school nil and home_educated true - school nil and home_educated false I've also fixed a bug where a school move for a home-schooled patient wouldn't update their home-schooled status, which would lead to them staying in the community clinic when they should instead be added to the school.
Following on from the previous commit this adds a migration which ensures that the patients are all valid following the introduction of new validation.
We can’t align using baseline as some button groups contain a Rails form button
This class is no longer needed as bottom border appearance is controlled via CSS.
|
thomasleese
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long lived branch/PR that contains work related to Release 1C. It will be periodically rebased from main. During the change freeze, new features should be PRed into this branch, not
main.