Send vaccination confirmations on a schedule #2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
changed the title
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
5091ad9 to
2d38ee8
Compare
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
2d38ee8 to
6e77223
Compare
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
6e77223 to
cb3a0ea
Compare
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
cb3a0ea to
f05f294
Compare
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
f05f294 to
de2cb39
Compare
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
de2cb39 to
6a0a0f0
Compare
tvararu
approved these changes
Nov 20, 2024
|
I like this pattern/approach |
This adds a new column on vaccination records for tracking when the confirmation email has been sent, allowing us to batch together and send emails at the end of the day.
The patient can be determined from the vaccination record.
And only if the vaccination confirmation email has already been sent, preventing these from being sent prematurely.
If a confirmation email was never sent. This prevents the parent receiving an email talking about a previous email have been sent in error when said email was never sent.
This adds a job which sends the vaccination confirmation emails at a specific time in the evening every day, ensuring that any vaccination records which have been created since the last ones were sent out, get processed. The job is set up such that it can be run at any point and it will send the confirmations for any new vaccination records that have been created since the last time the job ran will get their confirmation emails sent out.
thomasleese
force-pushed
the
vaccination-confirmation-evening
branch
from
6a0a0f0 to
58f40ca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a job which sends the vaccination confirmation emails at a specific time in the evening every day, ensuring that any vaccination records which have been created since the last ones were sent out, get processed.
The job is set up such that it can be run at any point and it will send the confirmations for any new vaccination records that have been created since the last time the job ran will get their confirmation emails sent out.
This also ensures that we don't send confirmation emails if a vaccination record is updated, unless a confirmation email was already sent out and it's the outcome of the vaccination that has changed.