Mav 932 create background service #3299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
added
feature
This is based on the production configuration that we will eventually need, but adds test users that will allow users to sign in and test Mavis without needing to be set up with CIS2. Co-authored-by: Lakshmi Murugappan <lakshmi.murugappan@tngtech.com>
This is based on the production configuration that we will eventually need, but adds test users that will allow users to sign in and test Mavis without needing to be set up with CIS2. This is based on #3305 but I needed to raise it as a branch in the repo (rather than a fork) so it can be deployed.
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
2def50e to
c5a011a
Compare
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
c5a011a to
99403fe
Compare
This fixes a number of linting issues related to the Terraform configuration by running `terraform fmt`. In the future we should include this as part of the CI checks to ensure it's always linted correctly.
This fixes a number of linting issues related to the Terraform configuration by running `terraform fmt`. In the future we should include this as part of the CI checks to ensure it's always linted correctly.
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
99403fe to
31f8e6f
Compare
- Default to deploying all - Optional input parameter to only deploy select services - Add output variables needed to trigger deploy from pipeline
- Required for double quotes to persist after sourcing - Otherwise json is invalid
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
8b0d239 to
4ed1427
Compare
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
4ed1427 to
01d66f8
Compare
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
01d66f8 to
d73c6ef
Compare
- For good-job service
- Add check to validate deployment successful
- Force deployment every time (even if no change in task_definition
- Aligns with behaviour of thrust service
- Ensure we properly escape quotation for query to handle variables
- Update the deploy mavis and continuous deployment pipelines - Ensure they accomodate server-type input parameter
TheOneFromNorway
force-pushed
the
MAV-932_create_background_service
branch
from
651fc7e to
89831a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.