Update deployment pipeline to work with modularized services #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
9eba8b9 to
ff44794
Compare
thomasleese
reviewed
Apr 4, 2025
TheOneFromNorway
force-pushed
the
create_modularized_ecs_services
branch
from
960e16c to
42e184b
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
ff44794 to
338d02e
Compare
TheOneFromNorway
force-pushed
the
create_modularized_ecs_services
branch
3 times, most recently
from
36d63b9 to
a647e9a
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
338d02e to
13bad73
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
15a4cdd to
4a30b6e
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
4a30b6e to
096c75c
Compare
TheOneFromNorway
force-pushed
the
create_modularized_ecs_services
branch
from
a647e9a to
1e793eb
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
096c75c to
94349ef
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
94349ef to
c9213f4
Compare
TheOneFromNorway
force-pushed
the
create_modularized_ecs_services
branch
6 times, most recently
from
d17f18b to
b5e4db1
Compare
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
3d3df4b to
0257075
Compare
bogsi17
approved these changes
Apr 8, 2025
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
0257075 to
27f6bf0
Compare
- Option to deploy all or only one type of services - When deploying all deploy in parallel to speed up process - Default to deploy all for deploying mavis - Always deploy all for continuous deployment
- To reflect modularized and multiple ecs services
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
from
27f6bf0 to
16ed7c2
Compare
|
bogsi17
added a commit
that referenced
this pull request
Apr 8, 2025
* In cases where a new ECS service is deployed, while the loadbalancer target group that is controlled by Codedeploy points to the "wrong" target group, terraform apply would result into an error that the new service is not attached to a valid target group. * This can be taken care of by assigning the currently active target group to this variable Previously, this could already be done by changing it temporarily in the terraform configuration, but having this as a variable allows for different values per environment This is part of a PR chain with #3323 as parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a PR chain with #3322 as parent