Make gap between PDS jobs configurable #3329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benilovj
approved these changes
Apr 8, 2025
This increases the threshold necessary to trigger a patient to be updated from PDS from 6 hours since the last update to 12 hours. Currently it takes about 24 hours to process all patients older than 6 hours, and we expect the number of patients to double in the next couple of weeks. Combining this change with a decrease in the gap between jobs should allow us to handle the increase in the number of patients.
Instead of using `each_with_index` we can use `find_each` and `with_index` to perform multiple batched queries to the database and require less memory.
thomasleese
force-pushed
the
pds-update-reduce-gap
branch
from
9ffe12e to
ac50cc6
Compare
This makes the gap between PDS jobs configurable in a settings variable, allowing us to change this value without needing to do deploy the code.
thomasleese
force-pushed
the
pds-update-reduce-gap
branch
from
ac50cc6 to
07a09d2
Compare
thomasleese
changed the title
|
thomasleese
added a commit
that referenced
this pull request
Apr 8, 2025
This adds a new environment variable to the task definition that allows us to configure the wait time between when PDS jobs are enqueued without needing a deployment, by storing the value in the parameter store. #3329 is the change to the application code which added the setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're modifying the way Good Job is deployed to hopefully reduce contention by reducing the number of parallel jobs processing at any one time. This should allow us to reduce the artificial gap we've imposed between PDS jobs and process patients at a quicker rate.
By making the value configurable we can change the gap between jobs without needing to deploy changes to the code.