Extract default target group to variable #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogsi17
force-pushed
the
MAV-818_default_lb_target_group
branch
from
8f5f6fe to
91d66f1
Compare
bogsi17
force-pushed
the
MAV-818_default_lb_target_group
branch
from
91d66f1 to
d31cc6c
Compare
bogsi17
changed the base branch from
v2.1.3-wip
to
update_workflows_for_modularized_services
TheOneFromNorway
force-pushed
the
update_workflows_for_modularized_services
branch
3 times, most recently
from
27f6bf0 to
16ed7c2
Compare
TheOneFromNorway
force-pushed
the
MAV-818_default_lb_target_group
branch
from
d31cc6c to
377f5b1
Compare
Base automatically changed from
update_workflows_for_modularized_services
to
main
April 8, 2025 13:20
* In cases where a new ECS service is deployed, while the loadbalancer target group that is controlled by Codedeploy points to the "wrong" target group, terraform apply would result into an error that the new service is not attached to a valid target group. * This can be taken care of by assigning the currently active target group to this variable
bogsi17
force-pushed
the
MAV-818_default_lb_target_group
branch
from
e400829 to
0da26aa
Compare
TheOneFromNorway
approved these changes
Apr 8, 2025
* Set the variable for preview since the currently active target group is green
bogsi17
force-pushed
the
MAV-818_default_lb_target_group
branch
from
6a1cf41 to
e07be8f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a new ECS service is deployed, while the loadbalancer target group that is controlled by Codedeploy points to the "wrong" target group, terraform apply would result into an error that the new service is not attached to a valid target group.
This can be taken care of by assigning the currently active target group to this variable
Previously, this could already be done by changing it temporarily in the terraform configuration, but having this as a variable allows for different values per environment
This is part of a PR chain with #3323 as parent