Don't send clinic invitations incorrectly #3357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
bb2856a to
6937cae
Compare
|
@jhenderson Your comment seems to have disappeared, but good catch, I've amended the commit to make sure the tests are actually working as expected. |
I deleted it because it did fail when I ran the full spec, so I wasn't 100% sure, but yeah it would make sense for the specific test you wrote to fail if we changed the logic. Also had this suggestion if you wanted to get rid of the |
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
6937cae to
94dc4a1
Compare
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
94dc4a1 to
cd311fa
Compare
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
cd311fa to
83494e8
Compare
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
83494e8 to
cceb100
Compare
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
2 times, most recently
from
4f854f4 to
2ef7c24
Compare
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
2ef7c24 to
92a05c2
Compare
This fixes a bug where patients who are eligible for multiple programmes were being sent clinic invitations where they shouldn't have been. The specific scenario is where a patient is vaccinated for one programme and consent refused for another, therefore the parents shouldn't receive an invitation to the clinic, but the code was incorrectly deciding that the patient should. The code wasn't treating the programmes individually, so it was seeing one programme as unvaccinated and another programme as consent given and deciding therefore that the patient should be sent the invitation.
thomasleese
force-pushed
the
fix-incorrect-clinic-session-invites
branch
from
92a05c2 to
74a14cf
Compare
|
misaka
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where patients who are eligible for multiple programmes were being sent clinic invitations where they shouldn't have been. The specific scenario is where a patient is vaccinated for one programme and consent refused for another, therefore the parents shouldn't receive an invitation to the clinic, but the code was incorrectly deciding that the patient should.
The code wasn't treating the programmes individually, so it was seeing one programme as unvaccinated and another programme as consent given and deciding therefore that the patient should be sent the invitation.