Accept import capitalisation differences

[alistair-white-horne-tng]

Implement some extra logic when importing, which:

• automatically accepts any capitalisation differences in relevant import fields, without staging the changes for review
• matches patients whose postcode only differs by capitalisation
• saves all incoming parental information to the existing matched parent

MAV-926

[thomasleese]

I think there's potential to refactor this method as I'm finding it a bit complicated/hard to read. I've got a suggestion below which I think works and I find easier to understand:

def stage_changes(attributes)
  attributes.each do |attr, new_value|
    current_value = public_send(attr)

    if normalised(new_value) == normalised(current_value)
      public_send("#{attr}=", new_value)
      pending_changes.delete(attr.to_s)
    else
      pending_changes[attr.to_s] = new_value
    end
  end

  save!
end

private

def normalised(value)
  value.respond_to?(:downcase) ? value.downcase : value
end

What do you think?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[thomasleese]

Hmm it seems like merging v2.2.2-wip in to main closed this, I think because it's a fork. You'll probably want to re-open it @alistair-white-horne-tng.

[alistair-white-horne-tng]

New PR for this change: #3588