Include prettier into pre-commit hooks #3396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
8eec6af to
d40d806
Compare
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
d40d806 to
e95da30
Compare
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
e95da30 to
9e2f8b6
Compare
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
9e2f8b6 to
2aec007
Compare
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
2aec007 to
f40ec21
Compare
TheOneFromNorway
force-pushed
the
pre-commit_implementation
branch
from
8d35b96 to
209ff11
Compare
- Ensure we are formatting properly and consistently
- Users can in principle choose to opt out of automatic hooks by not
installing the tool in the repo
- Simplicity of incluing linting into CI
- For stability we run them initially in parallel to existing linting
scripts
- Scalability and futher development is simple as we can use existing
solutions instead of implementing our own linting setup
- Use existing yarn setup for calling prettier
- Run with --write to replicate linting script behaviour
- Will run in parallel to existing linting script in ci for evaluation
purposes
TheOneFromNorway
force-pushed
the
include_prettier_in_pre-commit
branch
from
f40ec21 to
9f792ce
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a PR chain with 3001 as parent
This includes the mirrors-prettier repo into the pre-commit configuration. This is a different approach than the yarn implementation currently used but testing yields similar results. The two configurations will run in parallel in the lint pipeline with, allowing the pre-commit job to fail while the new approach is being tested