-
Notifications
You must be signed in to change notification settings - Fork 9
Prepare restriction of AWS permissions for github workflows #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e7f61f0
to
72bccfe
Compare
72bccfe
to
a534a2f
Compare
If we are running Looking at the |
@misaka You're right, I will add it |
a9c4fc0
to
a710595
Compare
f4cd1e6
to
09b2903
Compare
09b2903
to
496129f
Compare
496129f
to
4151e0d
Compare
71eff9c
to
0aaf1a1
Compare
0aaf1a1
to
dd9d56e
Compare
dd9d56e
to
2482517
Compare
* We want to restrict the IAM role used by the Github workflows such that it can only be assumed from the main branch. * This causes the problem that deployment workflows run from tags could not assume the role anymore * To mitigate this issue, this PR allows to specify the git tag that shall be deployed in a dedicated field. While the workflow can be run from main, this still allows to deploy a specific git tag. If no value is set, it defaults to the regular behaviour. * It is ensured that the terraform files and the docker image being deployed always originate from the same commit
* 'main' is the only protected branch, 'release' is not protected
9130fcf
to
987db19
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We agreed we'd leave the new CodeQL warning alone for now, and address in a later PR. 👍
We want to restrict the IAM role used by the Github workflows such that it can only be assumed by workflow runs from the main and release branches. This causes the problem that deployment workflows run from tags could not assume the role anymore.
To mitigate this issue and still allow deploying specific tags, this PR allows to specify the git tag that shall be deployed in a dedicated field. While the workflow can be run from main or release, this still allows to deploy a specific git tag. If no value is set, it defaults to the regular behaviour.