Add phone instructions for organisations and teams #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Apr 30, 2025
app/views/parent_interface/consent_forms/cannot_consent_responsibility.html.erb
Outdated
Show resolved
Hide resolved
murugapl
force-pushed
the
add-phone-instructions-to-organisations
branch
from
1454c94 to
067516a
Compare
murugapl
force-pushed
the
add-phone-instructions-to-organisations
branch
2 times, most recently
from
47456d1 to
d1ef7bb
Compare
thomasleese
reviewed
May 1, 2025
There was a problem hiding this comment.
Looks good. I think we should also update the generic_team method on the organisation to create the team with any instructions.
manage-vaccinations-in-schools/app/models/organisation.rb
Lines 70 to 72 in 17d2208
teams.create_with(email:, phone:, phone_instructions:).find_or_create_by!(name:)
murugapl
force-pushed
the
add-phone-instructions-to-organisations
branch
from
d1ef7bb to
626ce79
Compare
Added phone_instructions string field to organisations and teams models to store additional context for phone numbers. Updated tests to verify that the field can be populated both through the onboarding YAML and manual editing. This allows staff to provide callers with guidance on phone menu options.
Added phone instructions display to user-facing views and notify personalisation. Phone instructions now appear in brackets next to phone numbers across the application interface. Updated the Notify personalisation variables to include these instructions in all automated communications.
murugapl
force-pushed
the
add-phone-instructions-to-organisations
branch
from
626ce79 to
1914abc
Compare
|
thomasleese
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some organisations may need to provide additional guidance when sharing phone numbers (like menu options), and this change allows that information to be stored and consistently displayed throughout the application.
Added a phone_instructions string field to both organisation and team models, with corresponding database migrations. The instructions now appear in brackets next to phone numbers in all user-facing views and are included in the Notify personalisation for emails and text communications.
The onboarding process also supports importing these instructions.