Skip to content

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented May 5, 2025

This updates the designs of the pre-screening checks to match the latest designs in the prototype where the process has been simplified to have only a single checkbox rather than a checkbox for each question. The content has also been refreshed to match the medical guidance.

Associated change to the functional tests: NHSDigital/manage-vaccinations-in-schools-testing#335

Jira Issue - MAV-1127

Screenshots

Screenshot 2025-05-05 at 19 56 30 Screenshot 2025-05-07 at 07 41 44 Screenshot 2025-05-07 at 07 41 51

@thomasleese thomasleese added this to the v2.3.0 milestone May 5, 2025
@thomasleese thomasleese added the feature New functionality label May 5, 2025
@tvararu tvararu temporarily deployed to mavis-pr-3493 May 5, 2025 20:04 Inactive
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 0f02e38 to 798a7b2 Compare May 6, 2025 07:44
@thomasleese thomasleese marked this pull request as ready for review May 6, 2025 07:44
@tvararu tvararu temporarily deployed to mavis-pr-3493 May 6, 2025 07:45 Inactive
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 798a7b2 to b1b2cb2 Compare May 6, 2025 11:40
@tvararu tvararu temporarily deployed to mavis-pr-3493 May 6, 2025 11:40 Inactive
@paulrobertlloyd
Copy link
Contributor

@thomasleese The error message should be above the checkbox, not the preceding content. I also believe the error message should be:

Select if the child has confirmed all pre-screening statements are true

but you might need to confirm this with Melissa.

pre-screening-checks-error-message

@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from b1b2cb2 to ce12b90 Compare May 7, 2025 05:34
@tvararu tvararu temporarily deployed to mavis-pr-3493 May 7, 2025 05:34 Inactive
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch 2 times, most recently from e6e4cba to 0128030 Compare May 15, 2025 13:08
Copy link
Contributor

@jhenderson jhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally added the file "]" which has some git commit text, but apart from that LGTM.

@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 0128030 to 63ab716 Compare May 20, 2025 11:33
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 63ab716 to e9c1dff Compare May 23, 2025 20:32
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from e9c1dff to ff497f5 Compare June 3, 2025 08:40
@thomasleese thomasleese requested a review from a team as a code owner June 3, 2025 08:40
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch 3 times, most recently from 0937b34 to 2b8e9ba Compare June 4, 2025 11:11
@thomasleese thomasleese modified the milestones: v2.3.0, v2.2.6 Jun 9, 2025
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch 3 times, most recently from 2ff598c to e049924 Compare June 10, 2025 08:34
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 10, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 10, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 356ae9c to b586488 Compare June 10, 2025 18:27
@thomasleese thomasleese requested a review from a team as a code owner June 10, 2025 18:27
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 11, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 11, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch 2 times, most recently from f1ff383 to ee8a3ad Compare June 11, 2025 13:59
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 11, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
@thomasleese thomasleese changed the base branch from main to next June 12, 2025 13:58
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from ee8a3ad to 4216f24 Compare June 12, 2025 13:58
This refactors the pre-screening feature specs to ensure every supported
programme is fully working. This is important as some of the
pre-screening questions change according to each programme.
This updates the designs of the pre-screening checks to match the latest
designs in the prototype where the process has been simplified to have
only a single checkbox rather than a checkbox for each question. The
content has also been refreshed to match the medical guidance.
This removes a number of columns from the pre-screening model which are
no longer used and therefore can be safely removed.
This should improve the accessibility of the page by ensuring that the
pre-screening and vaccination sections are considered separate.
@thomasleese thomasleese force-pushed the redesign-pre-screening-single-question branch from 4216f24 to 07bead7 Compare June 12, 2025 14:22
Copy link

@thomasleese thomasleese merged commit eca1bcd into next Jun 12, 2025
9 checks passed
@thomasleese thomasleese deleted the redesign-pre-screening-single-question branch June 12, 2025 14:34
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 12, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
thomasleese added a commit to NHSDigital/manage-vaccinations-in-schools-testing that referenced this pull request Jun 15, 2025
In nhsuk/manage-vaccinations-in-schools#3493 the
pre-screening checks have been redesigned to be a single checkbox with
some list items on each check that needs to be taken. This updates the
tests to ensure they continue to work under this new design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants