Use checkboxes instead of radios for consent status filter #3521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenderson
approved these changes
May 9, 2025
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
092fa57 to
4079cee
Compare
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
5 times, most recently
from
edec95f to
66e48e8
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 10, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 10, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 10, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
66e48e8 to
ea9e2ed
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 11, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
ea9e2ed to
2440225
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 11, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
2440225 to
860ab7a
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 12, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 15, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
860ab7a to
a2683a9
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 17, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
a2683a9 to
3f7ed2b
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 18, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
There are a few filters for consent status that could in some scenarios be roughly equivalent (or require follow-up regardless of the specific status), for example ‘No response’ and ‘Conflicting consent’ might both warrant the parent needing to be phoned. Right now it’s only possible to select one consent status at a time. If we change it from radios to checkboxes, then we give teams more flexibility in how they whittle down lists of children with varying consent statuses. Jira-Issue: MAV-1130
thomasleese
force-pushed
the
multiple-consent-status-filter
branch
from
3f7ed2b to
db1ad83
Compare
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools-testing
that referenced
this pull request
Jun 18, 2025
In nhsuk/manage-vaccinations-in-schools#3521 the consent filters have been changed from radio buttons to check boxes. This commit updates the tests so they will continue to work under this new design. Jira-Issue: MAV-1130
|
thomasleese
added a commit
that referenced
this pull request
Jun 19, 2025
Use checkboxes instead of radios for consent status filter
thomasleese
added a commit
that referenced
this pull request
Jun 19, 2025
Use checkboxes instead of radios for consent status filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few filters for consent status that could in some scenarios be roughly equivalent (or require follow-up regardless of the specific status), for example ‘No response’ and ‘Conflicting consent’ might both warrant the parent needing to be phoned.
Right now it’s only possible to select one consent status at a time. If we change it from radios to checkboxes, then we give teams more flexibility in how they whittle down lists of children with varying consent statuses.
Associated change to the functional tests: NHSDigital/manage-vaccinations-in-schools-testing#336
Jira Issue - MAV-1130
Screenshot