-
Notifications
You must be signed in to change notification settings - Fork 9
TimelineRecords UI #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimelineRecords UI #3559
Conversation
4ee1935
to
93d5139
Compare
0d4f5fb
to
82ef38e
Compare
82ef38e
to
d8af2c9
Compare
e1f411b
to
331a694
Compare
331a694
to
2d03c8e
Compare
|
2d03c8e
to
d5e6d24
Compare
d5e6d24
to
d32e5c9
Compare
d32e5c9
to
018ae97
Compare
d2838b8
to
47ec7fb
Compare
f1780a5
to
8c21362
Compare
c89e29e
to
5d0a857
Compare
8c21362
to
a3d4586
Compare
a3d4586
to
cb46dac
Compare
Introduces a TimelineRecords class that collects and displays a chronological view of patient-related events across multiple record types. Features configurable detail display, audit trail integration, and privacy controls to ensure no PII is exposed.
cb46dac
to
ceeac97
Compare
Implements a front-end interface for the TimelineRecords module with: - Interactive filters for event types and detail levels - Tabular timeline view with chronological grouping - Controller and views in the Inspect::Timeline namespace - Routes restricted to test environments only - Comparison view to analyze events between patients
…n is selected Changed the default behavior of the sample_patient function to return nil when no comparison option is provided, instead of raising an error. Added a meaningful error message when an invalid comparison option is chosen.
A show_pii flag allows optional exclusion of personally-identifiable information from the event details and audited changes relating to a patient. This has been set to false by default in the controller, but can be toggled on or off with a check box in the UI.
ceeac97
to
730766c
Compare
Refactor details and audits config for TimelineRecords to make it mroe readable. The PII fields are separated and merged into the base fields to created "with_pii" variables
730766c
to
d2b3867
Compare
|
<% card.with_heading { "Customise timeline" } %> | ||
<%= form_with url: @url, | ||
method: :get, | ||
data: { module: "autosubmit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we've removed Stimulus from Mavis, probably since this was originally written (see b66c0f4). Not a show-stopper, but it would be nice to see if we can get this functionality back, although I suspect NHSUK won't support it directly so we'll have to bring Stimulus back.
@@ -0,0 +1,388 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this isn't in app/lib
? It feels like it should be to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple things I think we should sort, but it's more important now to just get this PR in. 🚀
An endpoint which serves a UI used to view events related to a patient record.
This is a tool designed for use by the Ops Support people, to visualise the patient data without having to use the console.
The information that can be displayed for each 'event' is as follows:
manage-vaccinations-in-schools/lib/timeline_records.rb
Lines 21 to 77 in 730766c
And the following audited changes are allowed:
manage-vaccinations-in-schools/lib/timeline_records.rb
Lines 89 to 133 in 730766c
These details include PII, but there is a
show_pii
flag that can be turned off in the controller to remove any identifiable information from the above lists