Don't set session when recording already had vaccinations #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
dont-store-session-on-already-had
branch
from
9c0e098 to
1c148f5
Compare
The session of a vaccination record is used to determine the location where the vaccination took place. When recording an "already had" vaccination, we don't know where the vaccination took place so it doesn't make sense to store a location
thomasleese
force-pushed
the
dont-store-session-on-already-had
branch
from
1c148f5 to
48c8390
Compare
|
|
#3551 is a better alternative to this, we'll continue to associate the records with the session they were recorded in, but their |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session of a vaccination record is used to determine the location where the vaccination took place. When recording an "already had" vaccination, we don't know where the vaccination took place so it doesn't make sense to store a location