Fix version number display in production #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Jun 5, 2025
murugapl
force-pushed
the
fix-version-number-footer
branch
from
f611cc0 to
1033c94
Compare
thomasleese
approved these changes
Jun 5, 2025
The previous implementation to display the Mavis version number in the footer of the app used the deploy git ref to create a file with the version number which was baked into the image. With the current deploy strategy, the image is only built during deploys to QA and test, before the version tag is even created. So the version number isn't displayed appropriately in production. This change uses environment variables to set the version number instead. The MAVIS_APP_VERSION environment variable is now set during infrastructure deployment and passed to the ECS containers. For production deployments, the version format is validated to ensure it follows semantic versioning (v1.2.3 format). This ensures the correct version number is displayed regardless of when the Docker image was built, as the version is determined at deployment time rather than build time.
murugapl
force-pushed
the
fix-version-number-footer
branch
from
1033c94 to
2cbe18e
Compare
|
thomasleese
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation to display the Mavis version number in the footer of the app used the deploy git ref to create a file with the version number which was baked into the image. With the current deploy strategy, the image is only built during deploys to QA and test, before the version tag is even created. So the version number isn't displayed appropriately in production.
This change uses environment variables to set the version number instead. The MAVIS_APP_VERSION environment variable is now set during infrastructure deployment and passed to the ECS containers. For production deployments, the version format is validated to ensure it follows semantic versioning (v1.2.3 format).
This ensures the correct version number is displayed regardless of when the Docker image was built, as the version is determined at deployment time rather than build time.