Fix data replication deployment #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bogsi17
commented
Jun 20, 2025
bogsi17
commented
- Now that the DB uses a custom KMS key, the role for deploying data replication resources needs access to this key.
- To keep the restrictions restrictive, any actions that would disable the key are still denied
* Now that the DB uses a custom KMS key, the role for deploying data replication resources needs access to this key. * To keep the restrictions restrictive, any actions that would disable the key are still denied
terraform/account/resources/iam_policy_DeployDataReplicationResources.json
Outdated
Show resolved
Hide resolved
bogsi17
force-pushed
the
data_replication_fix
branch
from
8ce29af to
56aeae9
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
56aeae9 to
ab7f3f6
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
ab7f3f6 to
6e31a3e
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
6e31a3e to
8905805
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
8905805 to
b079eab
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
b079eab to
68d6701
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
bcdb1f1 to
7c94304
Compare
bogsi17
force-pushed
the
data_replication_fix
branch
from
7c94304 to
7c4945a
Compare
* The data replication DB itself is being automatically backed up. This can't be turned off. We need to change the selector in a way that it only matches snapshots of the Production DB and not the data replication snapshots
bogsi17
force-pushed
the
data_replication_fix
branch
from
7c4945a to
717c718
Compare
|
TheOneFromNorway
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.