Draft session dates to prevent save on "back" #3799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
5 times, most recently
from
4ea2bc7 to
e1d3be6
Compare
misaka
reviewed
Jun 23, 2025
misaka
reviewed
Jun 23, 2025
misaka
reviewed
Jun 23, 2025
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
2 times, most recently
from
9ea0168 to
3b32acf
Compare
thomasleese
reviewed
Jul 9, 2025
There was a problem hiding this comment.
Overall the change looks good, however I think we can probably simplify this by using array attributes or Rails serialization rather than needing to manually JSON parse and dump the values ourselves.
We do this already for the health questions and this is fully supported by the RequestSessionPersistable module.
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
4 times, most recently
from
8687a51 to
d3068bf
Compare
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
from
d3068bf to
2f466fe
Compare
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
from
2f466fe to
3093767
Compare
The "back" button on the session dates edit page was broken. Even when one clicked back, the changes made were still saved. MAV-516 includes a bug report for this. By adding a new model which is a draft version of the session dates we can allow modification of session dates in the edit page without immediately saving them to the database.
The e2e tests contain tests for only one of the different invalid states as each type of invalid state is already tested in the unit tests. The one test that is included is just to test that errors are showing up at all.
MartinVanIJcken
force-pushed
the
draft-session-dates
branch
from
3093767 to
02f243f
Compare
|
|
This pull request is no longer up to date and would need significant reworking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "back" button on the session dates edit page was broken. Even when one clicked back, the changes made were still saved. MAV-516 includes a bug report for this.
By adding a new model which is a draft version of the session dates we can allow modification of session dates in the edit page without immediately saving them to the database.