Rate limit Immunisations API #4233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
Aug 11, 2025
misaka
force-pushed
the
imms-api-rate-limit
branch
from
020647d to
f285ad6
Compare
thomasleese
approved these changes
Aug 11, 2025
This is necessary as we'll be adding rate limiting for another NHS API service, the Immunisations API, and it has a different rate limit than PDS. Jira-Issue: MAV-1739
In the INT environment, and potentially the production one too, there will be a rate limit imposed by the Imms API's PDS link-up. Until they either increase that rate limit, or stop doing asynchronous PDS lookups, we need to ensure we take up only a small portion of their 5 tps limit. Jira-Issue: MAV-1739
misaka
force-pushed
the
imms-api-rate-limit
branch
from
f285ad6 to
4beabcb
Compare
|
MartinVanIJcken
pushed a commit
that referenced
this pull request
Aug 12, 2025
Rate limit Immunisations API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the INT environment, and potentially the production one too, there will be a rate limit imposed by the Imms API's PDS link-up. Until they either increase that rate limit, or stop doing asynchronous PDS lookups, we need to ensure we take up only a small portion of their 5 tps limit.
We don't have tests around rate limiting (that I can find), so we're relying on manual testing for this change.
Jira-Issue: MAV-1739