Skip to content

Improve formatting of year groups #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

Improve formatting of year groups #4243

merged 3 commits into from
Aug 12, 2025

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Aug 12, 2025 •
edited by benilovj
Loading

This makes a number of small changes to clarify the year groups when they're shown:

  • The registration is displayed after a comma as per the prototype.
  • The academic year is always show during the preparation period.

JIRA: MAV-1757

@thomasleese
Use concatenations rather than array join
d199546 
This updates the `patient_year_group` helper to concatenate strings
together rather than use `compact` and `join` to improve performance of
this helper method which is used throughout the service.
@thomasleese
Update formatting of year group with registration
8b33f9b 
This updates the formatting to match the latest designs where the
registration is shown after the year group with a comma.
@thomasleese
Show academic year during preparation period
7403bca 
If we're in the preparation period, it's not always clear which academic
year is being used to display a year group, therefore we should always
show the academic year during the preparation period.
@thomasleese thomasleese added this to the v2.17.0 milestone Aug 12, 2025
@thomasleese thomasleese requested a review from a team as a code owner August 12, 2025 06:15
@thomasleese thomasleese added the design tweak Small update to content or layout label Aug 12, 2025
@thomasleese thomasleese enabled auto-merge August 12, 2025 06:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tvararu tvararu temporarily deployed to mavis-pr-4243 August 12, 2025 06:18 Inactive
@thomasleese thomasleese merged commit 64fe6ea into next Aug 12, 2025
13 of 14 checks passed
@thomasleese thomasleese deleted the year-group-formatting branch August 12, 2025 08:25
MartinVanIJcken pushed a commit that referenced this pull request Aug 12, 2025
@thomasleese @MartinVanIJcken
Merge pull request #4243 from nhsuk/year-group-formatting
06164f7 
Improve formatting of year groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhenderson jhenderson jhenderson approved these changes

Assignees
No one assigned
Labels
design tweak Small update to content or layout
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasleese @jhenderson @tvararu