Use pending academic year instead of current #4244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the interface of the `Patient#year_group` method to ensure an academic year is always specified, meaning we're explicit about which academic year is being used to determine the year group.
This method was only being used in one place, in a controller, so this moves the code closer to where it's being used which also allows us to be more intentional about the academic year that is being used.
When viewing a patient outside the context of a session, this renders the information for a patient in the context of the pending academic year rather than the current one. This is to make the preparation period easier for users by showing year groups and sessions as they will be starting in September.
|
MartinVanIJcken
pushed a commit
that referenced
this pull request
Aug 12, 2025
Use pending academic year instead of current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a patient outside the context of a session, this renders the information for a patient in the context of the pending academic year rather than the current one. This is to make the preparation period easier for users by showing year groups and sessions as they will be starting in September.
JIRA: MAV-1757